Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-31 Thread Scott Wood
On Mon, Mar 31, 2008 at 11:08:58AM +0200, Laurent Pinchart wrote: > On Friday 28 March 2008 19:07, Scott Wood wrote: > > Yes, it tells you the virtual address when it's not an identity mapping. > > It's not currently used on CPM platforms, but might be used down the > > road with a QE device on

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-31 Thread Laurent Pinchart
On Friday 28 March 2008 19:07, Scott Wood wrote: > Laurent Pinchart wrote: > > On Friday 28 March 2008 18:11, Scott Wood wrote: > >> Laurent Pinchart wrote: > >>> Locating the end of the muram isn't as straightforward as it > >>> could be. As the current code already uses the beginning of the > >>>

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-28 Thread Scott Wood
Laurent Pinchart wrote: On Friday 28 March 2008 18:11, Scott Wood wrote: Laurent Pinchart wrote: Locating the end of the muram isn't as straightforward as it could be. As the current code already uses the beginning of the muram to store the BDs and data buffers, should I really bother locating

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-28 Thread Laurent Pinchart
On Friday 28 March 2008 18:11, Scott Wood wrote: > Laurent Pinchart wrote: > > Locating the end of the muram isn't as straightforward as it could be. As > > the current code already uses the beginning of the muram to store the BDs > > and data buffers, should I really bother locating the end or can

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-28 Thread Scott Wood
Laurent Pinchart wrote: Locating the end of the muram isn't as straightforward as it could be. As the current code already uses the beginning of the muram to store the BDs and data buffers, should I really bother locating the end or can I store the SMC parameter ram at the beginning as well ?

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-28 Thread Laurent Pinchart
On Thursday 27 March 2008 16:39, Scott Wood wrote: > On Thu, Mar 27, 2008 at 10:10:33AM +0100, Laurent Pinchart wrote: > > On Wednesday 26 March 2008 17:59, Scott Wood wrote: > > > This breaks the bootwrapper console. > > > > And of course I forgot about that :-) > > > > The boot wrapper code doe

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-28 Thread Scott Wood
On Fri, Mar 28, 2008 at 03:06:58PM +0100, Laurent Pinchart wrote: > arch/powerpc/boot/cpm-serial.c stores the udbg buffer descriptors at the > beginning of the muram. Should I move them at the end as well ? Sure; make sure to update the default descriptor addresses in the Kconfig. -Scott ___

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-28 Thread Laurent Pinchart
On Friday 28 March 2008 14:58, Laurent Pinchart wrote: > On Thursday 27 March 2008 16:39, Scott Wood wrote: > > On Thu, Mar 27, 2008 at 10:10:33AM +0100, Laurent Pinchart wrote: > > > On Wednesday 26 March 2008 17:59, Scott Wood wrote: > > > > This breaks the bootwrapper console. > > > > > > And o

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-28 Thread Laurent Pinchart
On Thursday 27 March 2008 16:39, Scott Wood wrote: > On Thu, Mar 27, 2008 at 10:10:33AM +0100, Laurent Pinchart wrote: > > On Wednesday 26 March 2008 17:59, Scott Wood wrote: > > > This breaks the bootwrapper console. > > > > And of course I forgot about that :-) > > > > The boot wrapper code doe

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-27 Thread Scott Wood
On Thu, Mar 27, 2008 at 10:10:33AM +0100, Laurent Pinchart wrote: > On Wednesday 26 March 2008 17:59, Scott Wood wrote: > > This breaks the bootwrapper console. > > And of course I forgot about that :-) > > The boot wrapper code doesn't have any dpram allocator. Any objection against > using a c

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-27 Thread Laurent Pinchart
On Wednesday 26 March 2008 17:59, Scott Wood wrote: > Laurent Pinchart wrote: > > @@ -138,7 +137,7 @@ > > device_type = "serial"; > > compatible = "fsl,mpc8248-smc-uart", > > "fsl,cpm2-smc-uart"; > > -

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-27 Thread Laurent Pinchart
On Wednesday 26 March 2008 16:57, Scott Wood wrote: > On Wed, Mar 26, 2008 at 12:20:42PM +0100, Laurent Pinchart wrote: > > diff --git a/arch/powerpc/boot/dts/ep8248e.dts b/arch/powerpc/boot/dts/ep8248e.dts > > index 5d2fb76..756758f 100644 > > --- a/arch/powerpc/boot/dts/ep8248e.dts > > +++ b/arc

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-26 Thread Scott Wood
Laurent Pinchart wrote: @@ -138,7 +137,7 @@ device_type = "serial"; compatible = "fsl,mpc8248-smc-uart", "fsl,cpm2-smc-uart"; - reg = <0x11a80 0x20 0x1100 0x4

Re: [PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-26 Thread Scott Wood
On Wed, Mar 26, 2008 at 12:20:42PM +0100, Laurent Pinchart wrote: > diff --git a/arch/powerpc/boot/dts/ep8248e.dts > b/arch/powerpc/boot/dts/ep8248e.dts > index 5d2fb76..756758f 100644 > --- a/arch/powerpc/boot/dts/ep8248e.dts > +++ b/arch/powerpc/boot/dts/ep8248e.dts > @@ -121,8 +121,7 @@ > >

[PATCHv2 2/3] ep8248e: Reference SMC parameter RAM base in the device tree.

2008-03-26 Thread Laurent Pinchart
This patch modifies the Embedded Planet EP8248E device tree to reference the SMC paramater RAM base register instead of the parameter RAM allocated by the boot loader. The cpm_uart driver will allocate parameter RAM itself, making the serial port initialisation independent of the boot loader. Sig