Re: [PATCHv2 2/2] powerpc: implement arch_scale_smt_power for Power7

2010-01-28 Thread Benjamin Herrenschmidt
> I've tested it with manually offlined threads and it behaves as I'd like > it to. Which is ? IE. I'm happy that you like how it behaves, but I'd like to u understand how that is so I can make sure I'm also happy with it :-) Cheers, Ben. ___ Linuxp

Re: [PATCHv2 2/2] powerpc: implement arch_scale_smt_power for Power7

2010-01-28 Thread Joel Schopp
What about an early exit if !cpu_has_feature(CPU_FTR_SMT) ? That would de-facto compile it out for 32-bit CPU platforms that don't support SMT at all and avoid some overhead on POWER3,4,970... If the SD_SHARE_CPUPOWER flag isn't set for the sched domain this function isn't called. So an ex

Re: [PATCHv2 2/2] powerpc: implement arch_scale_smt_power for Power7

2010-01-26 Thread Benjamin Herrenschmidt
On Tue, 2010-01-26 at 17:28 -0600, Joel Schopp wrote: > On Power7 processors running in SMT4 mode with 2, 3, or 4 idle threads > there is performance benefit to idling the higher numbered threads in > the core. > > This patch implements arch_scale_smt_power to dynamically update smt > thread po

[PATCHv2 2/2] powerpc: implement arch_scale_smt_power for Power7

2010-01-26 Thread Joel Schopp
On Power7 processors running in SMT4 mode with 2, 3, or 4 idle threads there is performance benefit to idling the higher numbered threads in the core. This patch implements arch_scale_smt_power to dynamically update smt thread power in these idle cases in order to prefer threads 0,1 over thread