Re: [PATCH v9 3/7] powerpc/code-patching: Use WARN_ON and fix check in poking_init

2022-11-02 Thread Benjamin Gray
On Wed, 2022-11-02 at 09:38 +, Christophe Leroy wrote: > Le 25/10/2022 à 06:44, Benjamin Gray a écrit : > > diff --git a/arch/powerpc/lib/code-patching.c > > b/arch/powerpc/lib/code-patching.c > > index 54e145247643..3b3b09d5d2e1 100644 > > --- a/arch/powerpc/lib/code-patching.c > > +++ b/arch/

Re: [PATCH v9 3/7] powerpc/code-patching: Use WARN_ON and fix check in poking_init

2022-11-02 Thread Christophe Leroy
Le 25/10/2022 à 06:44, Benjamin Gray a écrit : > BUG_ON() when failing to initialise the code patching window is > excessive, as most critical patching happens during boot before strict > RWX control is enabled. Failure to patch after boot is not inherently > fatal, so aborting the kernel is bett

[PATCH v9 3/7] powerpc/code-patching: Use WARN_ON and fix check in poking_init

2022-10-24 Thread Benjamin Gray
BUG_ON() when failing to initialise the code patching window is excessive, as most critical patching happens during boot before strict RWX control is enabled. Failure to patch after boot is not inherently fatal, so aborting the kernel is better determined by the caller. The return value of cpuhp_s