Re: [PATCH v8 7/7] PCI: Work around PCIe link training failures

2023-06-11 Thread Maciej W. Rozycki
On Thu, 4 May 2023, Bjorn Helgaas wrote: > We talked about reusing pcie_retrain_link() earlier. IIRC that didn't > work: ASPM needs to use PCI_EXP_LNKSTA_LT because not all devices > support PCI_EXP_LNKSTA_DLLLA, and you need PCI_EXP_LNKSTA_DLLLA > because the erratum makes PCI_EXP_LNKSTA_LT flap

Re: [PATCH v8 7/7] PCI: Work around PCIe link training failures

2023-05-14 Thread Maciej W. Rozycki
On Sun, 7 May 2023, Maciej W. Rozycki wrote: > > We're going to land this series this cycle, come hell or high water. > > Thank you for coming back to me and for your promise. I'll strive to > address your concerns next weekend. > > Unfortunately a PDU in my remote lab has botched up and I'v

Re: [PATCH v8 7/7] PCI: Work around PCIe link training failures

2023-05-07 Thread Maciej W. Rozycki
On Thu, 4 May 2023, Bjorn Helgaas wrote: > On Thu, Apr 06, 2023 at 01:21:31AM +0100, Maciej W. Rozycki wrote: > > Attempt to handle cases such as with a downstream port of the ASMedia > > ASM2824 PCIe switch where link training never completes and the link > > continues switching between speeds

Re: [PATCH v8 7/7] PCI: Work around PCIe link training failures

2023-05-04 Thread Bjorn Helgaas
On Thu, Apr 06, 2023 at 01:21:31AM +0100, Maciej W. Rozycki wrote: > Attempt to handle cases such as with a downstream port of the ASMedia > ASM2824 PCIe switch where link training never completes and the link > continues switching between speeds indefinitely with the data link layer > never rea

[PATCH v8 7/7] PCI: Work around PCIe link training failures

2023-04-05 Thread Maciej W. Rozycki
Attempt to handle cases such as with a downstream port of the ASMedia ASM2824 PCIe switch where link training never completes and the link continues switching between speeds indefinitely with the data link layer never reaching the active state. It has been observed with a downstream port of the