Re: [PATCH v8 40/45] drivers/of: Split unflatten_dt_node()

2016-05-01 Thread Gavin Shan
On Wed, Feb 17, 2016 at 08:30:42AM -0600, Rob Herring wrote: >On Tue, Feb 16, 2016 at 9:44 PM, Gavin Shan wrote: >> The function unflatten_dt_node() is called recursively to unflatten >> device nodes and properties in the FDT blob. It looks complicated >> and hard to be understood. >> >> This spli

Re: [PATCH v8 40/45] drivers/of: Split unflatten_dt_node()

2016-04-19 Thread Gavin Shan
On Wed, Feb 17, 2016 at 08:30:42AM -0600, Rob Herring wrote: >On Tue, Feb 16, 2016 at 9:44 PM, Gavin Shan wrote: >> The function unflatten_dt_node() is called recursively to unflatten >> device nodes and properties in the FDT blob. It looks complicated >> and hard to be understood. >> >> This spli

Re: [PATCH v8 40/45] drivers/of: Split unflatten_dt_node()

2016-02-17 Thread Rob Herring
On Tue, Feb 16, 2016 at 9:44 PM, Gavin Shan wrote: > The function unflatten_dt_node() is called recursively to unflatten > device nodes and properties in the FDT blob. It looks complicated > and hard to be understood. > > This splits the function into 3 functions: populate_properties(), > populate

[PATCH v8 40/45] drivers/of: Split unflatten_dt_node()

2016-02-16 Thread Gavin Shan
The function unflatten_dt_node() is called recursively to unflatten device nodes and properties in the FDT blob. It looks complicated and hard to be understood. This splits the function into 3 functions: populate_properties(), populate_node() and unflatten_dt_node(). populate_properties(), which i