Re: [PATCH v8 01/14] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-08 Thread Arnd Bergmann
On Tue, Oct 8, 2024, at 11:46, Christoph Hellwig wrote: > On Tue, Oct 08, 2024 at 09:50:09AM +0200, Julian Vetter wrote: >> lib/iomap_copy.c | 127 +++ > > On top of the previous comments: this really should be iomem_copy.c > instead. Right, I suggested

Re: [PATCH v8 01/14] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-08 Thread Christoph Hellwig
On Tue, Oct 08, 2024 at 09:50:09AM +0200, Julian Vetter wrote: > lib/iomap_copy.c | 127 +++ On top of the previous comments: this really should be iomem_copy.c instead.

[PATCH v8 01/14] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-08 Thread Julian Vetter
Various architectures have almost the same implementations for memcpy_{to,from}io and memset_io functions. So, consolidate them into the existing lib/iomap_copy.c. Reviewed-by: Yann Sionneau Signed-off-by: Julian Vetter --- Changes for v8: - Replaced shifts by 'qc *= ~0UL / 0xff' - Modification

Re: [PATCH v8 01/14] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-08 Thread Christoph Hellwig
On Tue, Oct 08, 2024 at 09:27:20AM +, Arnd Bergmann wrote: > > #endif /* CONFIG_TRACE_MMIO_ACCESS */ > > > > +extern void memcpy_fromio(void *to, const volatile void __iomem *from, > > + size_t count); > > +extern void memcpy_toio(volatile void __iomem *to, const void *fro

Re: [PATCH v8 01/14] Consolidate IO memcpy/memset into iomap_copy.c

2024-10-08 Thread Arnd Bergmann
On Tue, Oct 8, 2024, at 07:50, Julian Vetter wrote: > diff --git a/include/asm-generic/io.h b/include/asm-generic/io.h > index 80de699bf6af..f14655ed4d9d 100644 > --- a/include/asm-generic/io.h > +++ b/include/asm-generic/io.h > @@ -102,6 +102,12 @@ static inline void log_post_read_mmio(u64 val, u8