Re: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE()

2019-12-02 Thread David Miller
m-ker...@lists.infradead.org; >> linux-ker...@vger.kernel.org; Scott Wood ; Timur Tabi >> ; Rasmus Villemoes ; >> net...@vger.kernel.org >> Subject: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of >> IS_ERR_VALUE() > > Hi David, > > Would you help

RE: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE()

2019-12-02 Thread Leo Li
Timur Tabi > ; Rasmus Villemoes ; > net...@vger.kernel.org > Subject: [PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of > IS_ERR_VALUE() Hi David, Would you help to review patch 44-47 in the series? If it is fine with you, I can take these 4 patches with the whole series though soc tree

[PATCH v6 44/49] net/wan/fsl_ucc_hdlc: avoid use of IS_ERR_VALUE()

2019-11-28 Thread Rasmus Villemoes
When building this on a 64-bit platform gcc rightly warns that the error checking is broken (-ENOMEM stored in an u32 does not compare greater than (unsigned long)-MAX_ERRNO). Instead, now that qe_muram_alloc() returns s32, use that type to store the return value and use standard kernel style "ret