Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-14 Thread Reza Arbab
On Mon, Nov 14, 2016 at 10:59:43PM +1100, Michael Ellerman wrote: So I'm not opposed to this, but it is a little vague. What does the "hotpluggable" property really mean? Is it just a hint to the operating system? (which may or may not be Linux). Or is it a direction, "this memory must be able

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-14 Thread Michael Ellerman
Reza Arbab writes: > When movable nodes are enabled, any node containing only hotpluggable > memory is made movable at boot time. > > On x86, hotpluggable memory is discovered by parsing the ACPI SRAT, > making corresponding calls to memblock_mark_hotplug(). > > If we introduce a dt property to d

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-10 Thread Balbir Singh
On 08/11/16 10:44, Reza Arbab wrote: > When movable nodes are enabled, any node containing only hotpluggable > memory is made movable at boot time. > > On x86, hotpluggable memory is discovered by parsing the ACPI SRAT, > making corresponding calls to memblock_mark_hotplug(). > > If we introduc

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-10 Thread Reza Arbab
On Thu, Nov 10, 2016 at 11:56:02AM +1100, Balbir Singh wrote: Have you tested this across all combinations of skiboot/kexec/SLOF boots? I've tested it under qemu/grub, simics/skiboot, and via kexec. -- Reza Arbab

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-09 Thread Balbir Singh
On 08/11/16 10:44, Reza Arbab wrote: > When movable nodes are enabled, any node containing only hotpluggable > memory is made movable at boot time. > > On x86, hotpluggable memory is discovered by parsing the ACPI SRAT, > making corresponding calls to memblock_mark_hotplug(). > > If we introduc

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-09 Thread Reza Arbab
On Wed, Nov 09, 2016 at 12:12:55PM -0600, Rob Herring wrote: On Mon, Nov 7, 2016 at 5:44 PM, Reza Arbab wrote: + hotpluggable = of_get_flat_dt_prop(node, "linux,hotpluggable", NULL); Memory being hotpluggable doesn't seem like a linux property to me. I'd drop the linux prefix. Also, thi

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-09 Thread Rob Herring
On Mon, Nov 7, 2016 at 5:44 PM, Reza Arbab wrote: > When movable nodes are enabled, any node containing only hotpluggable > memory is made movable at boot time. > > On x86, hotpluggable memory is discovered by parsing the ACPI SRAT, > making corresponding calls to memblock_mark_hotplug(). > > If w

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-08 Thread Reza Arbab
On Tue, Nov 08, 2016 at 09:59:26AM +0800, kbuild test robot wrote: All errors (new ones prefixed by >>): drivers/of/fdt.c: In function 'early_init_dt_scan_memory': drivers/of/fdt.c:1064:3: error: implicit declaration of function 'memblock_mark_hotplug' cc1: some warnings being treated as

Re: [PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-07 Thread kbuild test robot
Hi Reza, [auto build test ERROR on powerpc/next] [also build test ERROR on v4.9-rc4 next-20161028] [cannot apply to mmotm/master] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Reza-Arbab/enable

[PATCH v6 4/4] of/fdt: mark hotpluggable memory

2016-11-07 Thread Reza Arbab
When movable nodes are enabled, any node containing only hotpluggable memory is made movable at boot time. On x86, hotpluggable memory is discovered by parsing the ACPI SRAT, making corresponding calls to memblock_mark_hotplug(). If we introduce a dt property to describe memory as hotpluggable, c