Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Ryan Roberts
On 25/06/2024 15:06, Matthew Wilcox wrote: > On Tue, Jun 25, 2024 at 02:41:18PM +0100, Ryan Roberts wrote: >> On 25/06/2024 14:06, Matthew Wilcox wrote: >>> On Tue, Jun 25, 2024 at 01:41:02PM +0100, Ryan Roberts wrote: On 25/06/2024 13:37, Baolin Wang wrote: [...] >>> For ot

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Matthew Wilcox
On Tue, Jun 25, 2024 at 02:41:18PM +0100, Ryan Roberts wrote: > On 25/06/2024 14:06, Matthew Wilcox wrote: > > On Tue, Jun 25, 2024 at 01:41:02PM +0100, Ryan Roberts wrote: > >> On 25/06/2024 13:37, Baolin Wang wrote: > >> > >> [...] > >> > > For other filesystems, like ext4, I did not found th

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Ryan Roberts
On 25/06/2024 14:06, Matthew Wilcox wrote: > On Tue, Jun 25, 2024 at 01:41:02PM +0100, Ryan Roberts wrote: >> On 25/06/2024 13:37, Baolin Wang wrote: >> >> [...] >> > For other filesystems, like ext4, I did not found the logic to determin > what > size of folio to allocate in writable

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Matthew Wilcox
On Tue, Jun 25, 2024 at 01:41:02PM +0100, Ryan Roberts wrote: > On 25/06/2024 13:37, Baolin Wang wrote: > > [...] > > >>> For other filesystems, like ext4, I did not found the logic to determin > >>> what > >>> size of folio to allocate in writable mmap() path > >> > >> Yes I'd be keen to unders

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Ryan Roberts
On 25/06/2024 13:37, Baolin Wang wrote: [...] >>> For other filesystems, like ext4, I did not found the logic to determin what >>> size of folio to allocate in writable mmap() path >> >> Yes I'd be keen to understand this to. When I was doing contpte, page cache >> would only allocate large folio

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Baolin Wang
On 2024/6/25 19:40, Ryan Roberts wrote: On 25/06/2024 08:23, Baolin Wang wrote: On 2024/6/25 11:16, Kefeng Wang wrote: On 2024/6/24 23:56, Ryan Roberts wrote: + Baolin Wang and Yin Fengwei, who maybe able to help with this. Hi Kefeng, Thanks for the report! On 24/06/2024 15:30, Kef

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Kefeng Wang
On 2024/6/25 15:23, Baolin Wang wrote: On 2024/6/25 11:16, Kefeng Wang wrote: On 2024/6/24 23:56, Ryan Roberts wrote: + Baolin Wang and Yin Fengwei, who maybe able to help with this. Hi Kefeng, Thanks for the report! On 24/06/2024 15:30, Kefeng Wang wrote: Hi Ryan, A big regressio

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Ryan Roberts
On 25/06/2024 08:23, Baolin Wang wrote: > > > On 2024/6/25 11:16, Kefeng Wang wrote: >> >> >> On 2024/6/24 23:56, Ryan Roberts wrote: >>> + Baolin Wang and Yin Fengwei, who maybe able to help with this. >>> >>> >>> Hi Kefeng, >>> >>> Thanks for the report! >>> >>> >>> On 24/06/2024 15:30, Kefeng

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-25 Thread Baolin Wang
On 2024/6/25 11:16, Kefeng Wang wrote: On 2024/6/24 23:56, Ryan Roberts wrote: + Baolin Wang and Yin Fengwei, who maybe able to help with this. Hi Kefeng, Thanks for the report! On 24/06/2024 15:30, Kefeng Wang wrote: Hi Ryan, A big regression on page-fault3("Separate file shared map

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-24 Thread Kefeng Wang
On 2024/6/24 23:56, Ryan Roberts wrote: + Baolin Wang and Yin Fengwei, who maybe able to help with this. Hi Kefeng, Thanks for the report! On 24/06/2024 15:30, Kefeng Wang wrote: Hi Ryan, A big regression on page-fault3("Separate file shared mapping page fault") testcase from will-it-sc

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-24 Thread Ryan Roberts
+ Baolin Wang and Yin Fengwei, who maybe able to help with this. Hi Kefeng, Thanks for the report! On 24/06/2024 15:30, Kefeng Wang wrote: > Hi Ryan, > > A big regression on page-fault3("Separate file shared mapping page > fault") testcase from will-it-scale on arm64, no issue on x86, > > ./

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-06-24 Thread Kefeng Wang
Hi Ryan, A big regression on page-fault3("Separate file shared mapping page fault") testcase from will-it-scale on arm64, no issue on x86, ./page_fault3_processes -t 128 -s 5 1) large folio disabled on ext4: 92378735 2) large folio enabled on ext4 + CONTPTE enabled 16164943 3) large fol

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-02-16 Thread Catalin Marinas
On Thu, Feb 15, 2024 at 10:32:05AM +, Ryan Roberts wrote: > There are situations where a change to a single PTE could cause the > contpte block in which it resides to become foldable (i.e. could be > repainted with the contiguous bit). Such situations arise, for example, > when user space tempo

Re: [PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-02-15 Thread Mark Rutland
On Thu, Feb 15, 2024 at 10:32:05AM +, Ryan Roberts wrote: > There are situations where a change to a single PTE could cause the > contpte block in which it resides to become foldable (i.e. could be > repainted with the contiguous bit). Such situations arise, for example, > when user space tempo

[PATCH v6 18/18] arm64/mm: Automatically fold contpte mappings

2024-02-15 Thread Ryan Roberts
There are situations where a change to a single PTE could cause the contpte block in which it resides to become foldable (i.e. could be repainted with the contiguous bit). Such situations arise, for example, when user space temporarily changes protections, via mprotect, for individual pages, such c