Re: [PATCH v6 1/2] ftrace: disable preemption when recursion locked

2021-10-26 Thread 王贇
On 2021/10/27 上午10:55, Steven Rostedt wrote: > On Wed, 27 Oct 2021 10:34:13 +0800 > 王贇 wrote: > >> +/* >> + * Preemption will be enabled (if it was previously enabled). >> + */ >> static __always_inline void trace_clear_recursion(int bit) >> { >> +WARN_ON_ONCE(bit < 0); > > Can you send

Re: [PATCH v6 1/2] ftrace: disable preemption when recursion locked

2021-10-26 Thread Steven Rostedt
On Wed, 27 Oct 2021 10:34:13 +0800 王贇 wrote: > +/* > + * Preemption will be enabled (if it was previously enabled). > + */ > static __always_inline void trace_clear_recursion(int bit) > { > + WARN_ON_ONCE(bit < 0); Can you send a v7 without the WARN_ON. This is an extremely hot path, and

[PATCH v6 1/2] ftrace: disable preemption when recursion locked

2021-10-26 Thread 王贇
As the documentation explained, ftrace_test_recursion_trylock() and ftrace_test_recursion_unlock() were supposed to disable and enable preemption properly, however currently this work is done outside of the function, which could be missing by mistake. And since the internal using of trace_test_and