Re: [PATCH v6 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node()

2018-11-07 Thread Frank Rowand
On 11/7/18 4:23 AM, Michael Ellerman wrote: > frowand.l...@gmail.com writes: > >> From: Frank Rowand >> >> "of: overlay: add missing of_node_get() in __of_attach_node_sysfs" > > It would be clearer if you said 'The previous commit "of: overlay ..." Will fix. >> added a missing of_node_get() t

Re: [PATCH v6 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node()

2018-11-07 Thread Michael Ellerman
frowand.l...@gmail.com writes: > From: Frank Rowand > > "of: overlay: add missing of_node_get() in __of_attach_node_sysfs" It would be clearer if you said 'The previous commit "of: overlay ..." > added a missing of_node_get() to __of_attach_node_sysfs(). This > results in a refcount imbalance

[PATCH v6 04/18] powerpc/pseries: add of_node_put() in dlpar_detach_node()

2018-11-05 Thread frowand . list
From: Frank Rowand "of: overlay: add missing of_node_get() in __of_attach_node_sysfs" added a missing of_node_get() to __of_attach_node_sysfs(). This results in a refcount imbalance for nodes attached with dlpar_attach_node(). The calling sequence from dlpar_attach_node() to __of_attach_node_sy