Re: [PATCH v6] PPC440EPx gpio driver

2008-10-09 Thread Stefan Roese
On Thursday 09 October 2008, Steven A. Falco wrote: > This patch adds support for the GPIO functions of PPC40x and PPC44x > SOCs. Thanks. Tested successfully on 405EP board. I only have one comment below left. > Signed-off-by: Steve Falco > --- > > I looked more closely at the datasheet. Stefa

Re: [PATCH v6] PPC440EPx gpio driver

2008-10-09 Thread David Brownell
On Thursday 09 October 2008, Anton Vorontsov wrote: > > > I've incorporated the other changes, with one exception.  I want > > ppc4xx_gpio_get() to return 0 or 1 (rather than Anton's comment that any > > non-zero value is ok), because when you use the new "export feature" in > > sysfs, you see the

Re: [PATCH v6] PPC440EPx gpio driver

2008-10-09 Thread Anton Vorontsov
On Thu, Oct 09, 2008 at 04:05:28PM -0400, Steven A. Falco wrote: > This patch adds support for the GPIO functions of PPC40x and PPC44x > SOCs. > > Signed-off-by: Steve Falco > --- > > I looked more closely at the datasheet. Stefan is correct that the > shadow registers are not needed for these

[PATCH v6] PPC440EPx gpio driver

2008-10-09 Thread Steven A. Falco
This patch adds support for the GPIO functions of PPC40x and PPC44x SOCs. Signed-off-by: Steve Falco --- I looked more closely at the datasheet. Stefan is correct that the shadow registers are not needed for these processors, because they have separate registers for input and output. I've inco