Re: [PATCH v5 1/4] smpboot: introduce SDTL_INIT() helper to tidy sched topology setup

2025-07-11 Thread Valentin Schneider
On 11/07/25 11:20, K Prateek Nayak wrote: > Tangential discussion: I was looking at this and was wondering why we > need a "tl->flags" when there is already sd_flags() function and we can > simply add SD_OVERLAP to sd_numa_flags(). > > I think "tl->flags" was needed when the idea of overlap domains

Re: [PATCH v5 1/4] smpboot: introduce SDTL_INIT() helper to tidy sched topology setup

2025-07-11 Thread Peter Zijlstra
On Fri, Jul 11, 2025 at 11:20:30AM +0530, K Prateek Nayak wrote: > On 7/10/2025 4:27 PM, Li Chen wrote: > > /* > > * .. and append 'j' levels of NUMA goodness. > > */ > > for (j = 1; j < nr_levels; i++, j++) { > > - tl[i] = (struct sched_domain_topology_level){ > > -

Re: [PATCH v5 1/4] smpboot: introduce SDTL_INIT() helper to tidy sched topology setup

2025-07-11 Thread Peter Zijlstra
On Thu, Jul 10, 2025 at 06:57:07PM +0800, Li Chen wrote: > From: Li Chen > > Define a small SDTL_INIT(maskfn, flagsfn, name) macro and use it to build the > sched_domain_topology_level array. Purely a cleanup; behaviour is unchanged. > > Signed-off-by: Li Chen > Suggested-by: Thomas Gleixner >

Re: [PATCH v5 1/4] smpboot: introduce SDTL_INIT() helper to tidy sched topology setup

2025-07-10 Thread K Prateek Nayak
On 7/10/2025 4:27 PM, Li Chen wrote: > /* >* .. and append 'j' levels of NUMA goodness. >*/ > for (j = 1; j < nr_levels; i++, j++) { > - tl[i] = (struct sched_domain_topology_level){ > - .mask = sd_numa_mask, > - .sd_fl

[PATCH v5 1/4] smpboot: introduce SDTL_INIT() helper to tidy sched topology setup

2025-07-10 Thread Li Chen
From: Li Chen Define a small SDTL_INIT(maskfn, flagsfn, name) macro and use it to build the sched_domain_topology_level array. Purely a cleanup; behaviour is unchanged. Signed-off-by: Li Chen Suggested-by: Thomas Gleixner Tested-by: K Prateek Nayak --- arch/powerpc/kernel/smp.c | 34 +++