Re: [PATCH v5 1/3] printf: convert self-test to KUnit

2025-03-11 Thread Tamir Duberstein
On Thu, Mar 6, 2025 at 7:25 AM Petr Mladek wrote: > > On Fri 2025-02-21 15:34:30, Tamir Duberstein wrote: > > Convert the printf() self-test to a KUnit test. > > > > In the interest of keeping the patch reasonably-sized this doesn't > > refactor the tests into proper parameterized tests - it's all

Re: [PATCH v5 1/3] printf: convert self-test to KUnit

2025-03-08 Thread Tamir Duberstein
On Fri, Mar 7, 2025 at 10:55 AM Petr Mladek wrote: > > Honestly, I am not able to find how the KUNIT_FAIL() actually prints > the message. I can't find how assert_format() is defined. KUNIT_FAIL -> KUNIT_FAIL_ASSERTION -> _KUNIT_FAILED -> __kunit_do_failed_assertion -> kunit_fail -> kunit_print_s

Re: [PATCH v5 1/3] printf: convert self-test to KUnit

2025-03-07 Thread Tamir Duberstein
On Fri, Mar 7, 2025 at 11:01 AM Petr Mladek wrote: > > On Thu 2025-03-06 09:25:43, Tamir Duberstein wrote: > > On Thu, Mar 6, 2025 at 7:25 AM Petr Mladek wrote: > > > > > > On Fri 2025-02-21 15:34:30, Tamir Duberstein wrote: > > > > Convert the printf() self-test to a KUnit test. > > > > > > > >

Re: [PATCH v5 1/3] printf: convert self-test to KUnit

2025-03-07 Thread Petr Mladek
On Thu 2025-03-06 09:25:43, Tamir Duberstein wrote: > On Thu, Mar 6, 2025 at 7:25 AM Petr Mladek wrote: > > > > On Fri 2025-02-21 15:34:30, Tamir Duberstein wrote: > > > Convert the printf() self-test to a KUnit test. > > > > > > In the interest of keeping the patch reasonably-sized this doesn't >

Re: [PATCH v5 1/3] printf: convert self-test to KUnit

2025-03-07 Thread Petr Mladek
On Thu 2025-03-06 09:41:44, Tamir Duberstein wrote: > On Thu, Mar 6, 2025 at 9:25 AM Tamir Duberstein wrote: > > > > On Thu, Mar 6, 2025 at 7:25 AM Petr Mladek wrote: > > > > > > On Fri 2025-02-21 15:34:30, Tamir Duberstein wrote: > > > > Convert the printf() self-test to a KUnit test. > > > > >

Re: [PATCH v5 1/3] printf: convert self-test to KUnit

2025-03-06 Thread Tamir Duberstein
On Thu, Mar 6, 2025 at 9:25 AM Tamir Duberstein wrote: > > On Thu, Mar 6, 2025 at 7:25 AM Petr Mladek wrote: > > > > On Fri 2025-02-21 15:34:30, Tamir Duberstein wrote: > > > Convert the printf() self-test to a KUnit test. > > > > > > [...] > > > > > > 2. What was the motivation to remove the tra

Re: [PATCH v5 1/3] printf: convert self-test to KUnit

2025-03-06 Thread Petr Mladek
On Fri 2025-02-21 15:34:30, Tamir Duberstein wrote: > Convert the printf() self-test to a KUnit test. > > In the interest of keeping the patch reasonably-sized this doesn't > refactor the tests into proper parameterized tests - it's all one big > test case. > > Signed-off-by: Tamir Duberstein >

[PATCH v5 1/3] printf: convert self-test to KUnit

2025-02-21 Thread Tamir Duberstein
Convert the printf() self-test to a KUnit test. In the interest of keeping the patch reasonably-sized this doesn't refactor the tests into proper parameterized tests - it's all one big test case. Signed-off-by: Tamir Duberstein --- Documentation/core-api/printk-formats.rst | 4 +- MAINTAINE