Re: [alsa-devel] [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-23 Thread Mark Brown
On Fri, Aug 23, 2013 at 02:41:44PM -0700, Mike Turquette wrote: > Seems like the regulator framework is solving this with the new > regulator_get_optional() call. This leaves the > optional-versus-not-optional logic up to the driver. That is possibly for a slightly different case but perhaps not.

Re: [alsa-devel] [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-23 Thread Mike Turquette
Quoting Sascha Hauer (2013-08-23 07:01:28) > On Fri, Aug 23, 2013 at 01:58:15PM +0100, Mark Rutland wrote: > > On Fri, Aug 23, 2013 at 07:34:21AM +0100, Sascha Hauer wrote: > > > On Fri, Aug 23, 2013 at 12:49:19AM +0200, Tomasz Figa wrote: > > > > On Thursday 22 of August 2013 15:43:31 Mike Turquet

Re: [alsa-devel] [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-23 Thread Mark Rutland
[trimming a bit of useless context] > > > > > > Background to why it might be a good idea to connect a ground clock > > > > > > to the unconnected input pins is that a driver has a chance to > > > > > > successfully grab all clocks. Otherwise how does the driver > > > > > > distinguish > > > > > >

Re: [alsa-devel] [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-23 Thread Sascha Hauer
On Fri, Aug 23, 2013 at 01:58:15PM +0100, Mark Rutland wrote: > On Fri, Aug 23, 2013 at 07:34:21AM +0100, Sascha Hauer wrote: > > On Fri, Aug 23, 2013 at 12:49:19AM +0200, Tomasz Figa wrote: > > > On Thursday 22 of August 2013 15:43:31 Mike Turquette wrote: > > > > Quoting Sascha Hauer (2013-08-22

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-23 Thread Mark Rutland
On Fri, Aug 23, 2013 at 07:34:21AM +0100, Sascha Hauer wrote: > On Fri, Aug 23, 2013 at 12:49:19AM +0200, Tomasz Figa wrote: > > On Thursday 22 of August 2013 15:43:31 Mike Turquette wrote: > > > Quoting Sascha Hauer (2013-08-22 14:00:35) > > > > > > > On Thu, Aug 22, 2013 at 01:09:31PM +0100, Mar

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-23 Thread Mark Rutland
On Thu, Aug 22, 2013 at 10:00:35PM +0100, Sascha Hauer wrote: > On Thu, Aug 22, 2013 at 01:09:31PM +0100, Mark Rutland wrote: > > On Thu, Aug 22, 2013 at 08:19:10AM +0100, Mike Turquette wrote: > > > Quoting Tomasz Figa (2013-08-21 14:34:55) > > > > On Wednesday 21 of August 2013 09:50:15 Mark Rutl

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-22 Thread Sascha Hauer
On Fri, Aug 23, 2013 at 12:49:19AM +0200, Tomasz Figa wrote: > On Thursday 22 of August 2013 15:43:31 Mike Turquette wrote: > > Quoting Sascha Hauer (2013-08-22 14:00:35) > > > > > On Thu, Aug 22, 2013 at 01:09:31PM +0100, Mark Rutland wrote: > > > > On Thu, Aug 22, 2013 at 08:19:10AM +0100, Mike

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-22 Thread Tomasz Figa
On Thursday 22 of August 2013 15:43:31 Mike Turquette wrote: > Quoting Sascha Hauer (2013-08-22 14:00:35) > > > On Thu, Aug 22, 2013 at 01:09:31PM +0100, Mark Rutland wrote: > > > On Thu, Aug 22, 2013 at 08:19:10AM +0100, Mike Turquette wrote: > > > > Quoting Tomasz Figa (2013-08-21 14:34:55) > >

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-22 Thread Mike Turquette
Quoting Sascha Hauer (2013-08-22 14:00:35) > On Thu, Aug 22, 2013 at 01:09:31PM +0100, Mark Rutland wrote: > > On Thu, Aug 22, 2013 at 08:19:10AM +0100, Mike Turquette wrote: > > > Quoting Tomasz Figa (2013-08-21 14:34:55) > > > > On Wednesday 21 of August 2013 09:50:15 Mark Rutland wrote: > > > >

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-22 Thread Sascha Hauer
On Thu, Aug 22, 2013 at 01:09:31PM +0100, Mark Rutland wrote: > On Thu, Aug 22, 2013 at 08:19:10AM +0100, Mike Turquette wrote: > > Quoting Tomasz Figa (2013-08-21 14:34:55) > > > On Wednesday 21 of August 2013 09:50:15 Mark Rutland wrote: > > > > On Tue, Aug 20, 2013 at 01:06:25AM +0100, Mike Turq

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-22 Thread Mark Rutland
On Thu, Aug 22, 2013 at 08:19:10AM +0100, Mike Turquette wrote: > Quoting Tomasz Figa (2013-08-21 14:34:55) > > On Wednesday 21 of August 2013 09:50:15 Mark Rutland wrote: > > > On Tue, Aug 20, 2013 at 01:06:25AM +0100, Mike Turquette wrote: > > > > Quoting Mark Rutland (2013-08-19 02:35:43) > > >

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-22 Thread Mike Turquette
Quoting Tomasz Figa (2013-08-21 14:34:55) > On Wednesday 21 of August 2013 09:50:15 Mark Rutland wrote: > > On Tue, Aug 20, 2013 at 01:06:25AM +0100, Mike Turquette wrote: > > > Quoting Mark Rutland (2013-08-19 02:35:43) > > > > > > > On Sat, Aug 17, 2013 at 04:17:18PM +0100, Tomasz Figa wrote: >

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-21 Thread Tomasz Figa
On Wednesday 21 of August 2013 09:50:15 Mark Rutland wrote: > On Tue, Aug 20, 2013 at 01:06:25AM +0100, Mike Turquette wrote: > > Quoting Mark Rutland (2013-08-19 02:35:43) > > > > > On Sat, Aug 17, 2013 at 04:17:18PM +0100, Tomasz Figa wrote: > > > > On Saturday 17 of August 2013 16:53:16 Sascha

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-21 Thread Mark Rutland
On Tue, Aug 20, 2013 at 01:06:25AM +0100, Mike Turquette wrote: > Quoting Mark Rutland (2013-08-19 02:35:43) > > On Sat, Aug 17, 2013 at 04:17:18PM +0100, Tomasz Figa wrote: > > > On Saturday 17 of August 2013 16:53:16 Sascha Hauer wrote: > > > > On Sat, Aug 17, 2013 at 02:28:04PM +0200, Tomasz Fig

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Mike Turquette
Quoting Mark Rutland (2013-08-19 02:35:43) > On Sat, Aug 17, 2013 at 04:17:18PM +0100, Tomasz Figa wrote: > > On Saturday 17 of August 2013 16:53:16 Sascha Hauer wrote: > > > On Sat, Aug 17, 2013 at 02:28:04PM +0200, Tomasz Figa wrote: > > > > > > > Also I would make this option required. Use a dum

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Mark Rutland
On Sat, Aug 17, 2013 at 04:17:18PM +0100, Tomasz Figa wrote: > On Saturday 17 of August 2013 16:53:16 Sascha Hauer wrote: > > On Sat, Aug 17, 2013 at 02:28:04PM +0200, Tomasz Figa wrote: > > > > > > Also I would make this option required. Use a dummy clock for > > > > > > mux > > > > > > inputs tha

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Saturday 17 of August 2013 17:14:09 Sascha Hauer wrote: > On Sat, Aug 17, 2013 at 02:56:11PM +0200, Tomasz Figa wrote: > > Hi Nicolin, > > > > > First, you are right that all the properties you just commented are > > > software configurations. And I got the point that device tree now > > > can'

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Saturday 17 of August 2013 16:53:16 Sascha Hauer wrote: > On Sat, Aug 17, 2013 at 02:28:04PM +0200, Tomasz Figa wrote: > > > > > Also I would make this option required. Use a dummy clock for > > > > > mux > > > > > inputs that are grounded for a specific SoC. > > > > > > > > Some clocks are not

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Sascha Hauer
On Sat, Aug 17, 2013 at 05:13:20PM +0200, Tomasz Figa wrote: > On Saturday 17 of August 2013 17:00:02 Sascha Hauer wrote: > > On Sat, Aug 17, 2013 at 02:26:40PM +0200, Tomasz Figa wrote: > > > > You mean tx<0-7>. > > > > > > > > Also I would make this option required. Use a dummy clock for mux > >

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Saturday 17 of August 2013 17:00:02 Sascha Hauer wrote: > On Sat, Aug 17, 2013 at 02:26:40PM +0200, Tomasz Figa wrote: > > > You mean tx<0-7>. > > > > > > Also I would make this option required. Use a dummy clock for mux > > > inputs that are grounded for a specific SoC. > > > > Why do you nee

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Sascha Hauer
On Sat, Aug 17, 2013 at 02:56:11PM +0200, Tomasz Figa wrote: > Hi Nicolin, > > First, you are right that all the properties you just commented are > > software configurations. And I got the point that device tree now > > can't allow any software configuration even if the actual hardware > > connect

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Sascha Hauer
On Sat, Aug 17, 2013 at 02:26:40PM +0200, Tomasz Figa wrote: > > You mean tx<0-7>. > > > > Also I would make this option required. Use a dummy clock for mux inputs > > that are grounded for a specific SoC. > > Why do you need a dummy clock? > > The driver can simply try to grab all the possible

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Sascha Hauer
On Sat, Aug 17, 2013 at 02:28:04PM +0200, Tomasz Figa wrote: > > > > Also I would make this option required. Use a dummy clock for mux > > > > inputs that are grounded for a specific SoC. > > > > > > Some clocks are not from CCM and we haven't defined in imx6q-clk.txt, > > > so in most cases we ca

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
Hi Nicolin, On Friday 16 of August 2013 12:43:31 Nicolin Chen wrote: > Hi Tomasz, > >Thank you for the comments. You're welcome. >I'll revise them in v6. >And below is my reply for you comments. Thanks for your reply. > On Thu, Aug 15, 2013 at 02:18:22PM +0200, Tomasz Figa wrote:

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Friday 16 of August 2013 12:11:51 Sascha Hauer wrote: > On Fri, Aug 16, 2013 at 05:53:58PM +0800, Nicolin Chen wrote: > > On Fri, Aug 16, 2013 at 10:56:32AM +0200, Sascha Hauer wrote: > > > > "tx<0-8>" OptionalTx clock source for spdif playback. > > > > > > > >

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Friday 16 of August 2013 10:56:32 Sascha Hauer wrote: > On Fri, Aug 16, 2013 at 04:01:25PM +0800, Nicolin Chen wrote: > > Hi Sascha, > > > >Thank you for the detailed comments. > > > > On Fri, Aug 16, 2013 at 09:08:18AM +0200, Sascha Hauer wrote: > > > Which of them the driver should use i

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Nicolin Chen
On Fri, Aug 16, 2013 at 12:11:51PM +0200, Sascha Hauer wrote: > > Some clocks are not from CCM and we haven't defined in imx6q-clk.txt, > > so in most cases we can't provide a phandle for them, eg: spdif_ext. > > I think it's a bit hard to force it to be 'required'. An 'optional' > > looks more fle

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Sascha Hauer
On Fri, Aug 16, 2013 at 05:53:58PM +0800, Nicolin Chen wrote: > On Fri, Aug 16, 2013 at 10:56:32AM +0200, Sascha Hauer wrote: > > > "tx<0-8>" OptionalTx clock source for spdif playback. > > > If absent, will use core clock. > > > The index

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Nicolin Chen
On Fri, Aug 16, 2013 at 10:56:32AM +0200, Sascha Hauer wrote: > > "tx<0-8>" OptionalTx clock source for spdif playback. > > If absent, will use core clock. > > The index from 0 to 8 is identical > > to the

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Sascha Hauer
On Fri, Aug 16, 2013 at 04:01:25PM +0800, Nicolin Chen wrote: > Hi Sascha, > >Thank you for the detailed comments. > > On Fri, Aug 16, 2013 at 09:08:18AM +0200, Sascha Hauer wrote: > > Which of them the driver should use is configuration and thus normally > > should *not* be described in the

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Nicolin Chen
Hi Sascha, Thank you for the detailed comments. On Fri, Aug 16, 2013 at 09:08:18AM +0200, Sascha Hauer wrote: > Which of them the driver should use is configuration and thus normally > should *not* be described in the devicetree. However, there may be no > good way for the driver to know which

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Sascha Hauer
On Fri, Aug 16, 2013 at 12:43:31PM +0800, Nicolin Chen wrote: > Hi Tomasz, > >Thank you for the comments. I'll revise them in v6. >And below is my reply for you comments. > > On Thu, Aug 15, 2013 at 02:18:22PM +0200, Tomasz Figa wrote: > > > + - clock-names : Includes the following en

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-15 Thread Nicolin Chen
Hi Tomasz, Thank you for the comments. I'll revise them in v6. And below is my reply for you comments. On Thu, Aug 15, 2013 at 02:18:22PM +0200, Tomasz Figa wrote: > > + - clock-names : Includes the following entries: > > + nametypecomments > > + "core"

[PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-15 Thread Nicolin Chen
This patch add S/PDIF controller driver for Freescale SoC. Signed-off-by: Nicolin Chen --- .../devicetree/bindings/sound/fsl,spdif.txt| 76 ++ sound/soc/fsl/Kconfig |3 + sound/soc/fsl/Makefile |2 + sound/soc/fsl/fsl_spd