Re: [PATCH v5 05/12] powerpc/eeh: EEH for pSeries hot plug

2019-09-23 Thread Nathan Lynch
Sam Bobroff writes: > Thanks, this does look like a bug to me. I couldn't replicate your crash > (even with CONFIG_SLUB_DEBUG_ON) but I think I do see a bug there. > > Does the below patch also fix it for you? Yes, this works as well, thanks. > diff --git a/arch/powerpc/kernel/eeh.c b/arch/powe

Re: [PATCH v5 05/12] powerpc/eeh: EEH for pSeries hot plug

2019-09-22 Thread Sam Bobroff
On Thu, Sep 19, 2019 at 03:28:40PM -0500, Nathan Lynch wrote: > Hello Sam, > > Sam Bobroff writes: > > On PowerNV and pSeries, devices currently acquire EEH support from > > several different places: Boot-time devices from eeh_probe_devices() > > and eeh_addr_cache_build(), Virtual Function devic

Re: [PATCH v5 05/12] powerpc/eeh: EEH for pSeries hot plug

2019-09-19 Thread Nathan Lynch
"Oliver O'Halloran" writes: > On Fri, Sep 20, 2019 at 6:28 AM Nathan Lynch wrote: >> >> Hello Sam, >> >> Sam Bobroff writes: >> >> With this change, I get a crash (use after free by the looks of it) when >> I remove and then add a pci device in qemu: >> >> $ qemu-system-ppc64 -M pseries -append

Re: [PATCH v5 05/12] powerpc/eeh: EEH for pSeries hot plug

2019-09-19 Thread Oliver O'Halloran
On Fri, Sep 20, 2019 at 6:28 AM Nathan Lynch wrote: > > Hello Sam, > > Sam Bobroff writes: > > With this change, I get a crash (use after free by the looks of it) when > I remove and then add a pci device in qemu: > > $ qemu-system-ppc64 -M pseries -append 'debug console=hvc0' \ > -nographic -v

Re: [PATCH v5 05/12] powerpc/eeh: EEH for pSeries hot plug

2019-09-19 Thread Nathan Lynch
Hello Sam, Sam Bobroff writes: > On PowerNV and pSeries, devices currently acquire EEH support from > several different places: Boot-time devices from eeh_probe_devices() > and eeh_addr_cache_build(), Virtual Function devices from the pcibios > bus add device hooks and hot plugged devices from pc

Re: [PATCH v5 05/12] powerpc/eeh: EEH for pSeries hot plug

2019-08-20 Thread Michael Ellerman
Sam Bobroff writes: > diff --git a/arch/powerpc/kernel/of_platform.c > b/arch/powerpc/kernel/of_platform.c > index 427fc22f72b6..11c807468ab5 100644 > --- a/arch/powerpc/kernel/of_platform.c > +++ b/arch/powerpc/kernel/of_platform.c > @@ -81,7 +81,8 @@ static int of_pci_phb_probe(struct platform_

[PATCH v5 05/12] powerpc/eeh: EEH for pSeries hot plug

2019-08-15 Thread Sam Bobroff
On PowerNV and pSeries, devices currently acquire EEH support from several different places: Boot-time devices from eeh_probe_devices() and eeh_addr_cache_build(), Virtual Function devices from the pcibios bus add device hooks and hot plugged devices from pci_hp_add_devices() (with other platforms