Re: [PATCH v5 01/17] powerpc/fsl-pci: improve clock API use

2013-11-21 Thread Gerhard Sittig
[ summary: the PCI driver change of mine looks innocent yet raises questions (not for the current situation, but in the face of potential future changes); these concerns were not introduced by me but were "inherited" from the former implementation, as I understand it let's drop my patch

Re: [PATCH v5 01/17] powerpc/fsl-pci: improve clock API use

2013-11-19 Thread Scott Wood
On Mon, 2013-11-18 at 00:06 +0100, Gerhard Sittig wrote: > make the Freescale PCI driver get, prepare and enable the PCI clock > during probe(); the clock gets put upon device shutdown by the devm > approach > > clock lookup is non-fatal as not all platforms may provide clock specs > in their devi

[PATCH v5 01/17] powerpc/fsl-pci: improve clock API use

2013-11-17 Thread Gerhard Sittig
make the Freescale PCI driver get, prepare and enable the PCI clock during probe(); the clock gets put upon device shutdown by the devm approach clock lookup is non-fatal as not all platforms may provide clock specs in their device tree or implement a device tree based clock provider, but failure