Re: [PATCH v5] spi: Add PPC4xx SPI driver

2009-01-06 Thread Stefan Roese
Hi Wolfgang, On Monday 05 January 2009, Wolfgang Denk wrote: > > IIRC (I didn't write the original version of this driver) then this > > comments simply refers to the fact that the platform can select a maximum > > SPI frequency via spi->max_speed_hz which is pretty obvious. So I'll just > > remov

Re: [spi-devel-general] [PATCH v5] spi: Add PPC4xx SPI driver

2009-01-06 Thread Stefan Roese
Hi Anton, On Tuesday 06 January 2009, Anton Vorontsov wrote: > > This adds a SPI driver for the SPI controller found in the IBM/AMCC > > 4xx PowerPC's. > > > > Signed-off-by: Stefan Roese > > Signed-off-by: Wolfgang Ocker > > Acked-by: Josh Boyer > > --- > > [...] > > > +static unsigned int of_

Re: [spi-devel-general] [PATCH v5] spi: Add PPC4xx SPI driver

2009-01-05 Thread Anton Vorontsov
Hi Stefan, On Tue, Nov 25, 2008 at 04:48:08PM +0100, Stefan Roese wrote: > This adds a SPI driver for the SPI controller found in the IBM/AMCC > 4xx PowerPC's. > > Signed-off-by: Stefan Roese > Signed-off-by: Wolfgang Ocker > Acked-by: Josh Boyer > --- [...] > +static unsigned int of_num_gpios

Re: [PATCH v5] spi: Add PPC4xx SPI driver

2009-01-05 Thread Wolfgang Denk
Dear Stefan, In message <200901051912.25874...@denx.de> you wrote: > > > > + /* Write new configration */ > > > + out_8(&hw->regs->mode, cs->mode); > > > + > > > + /* > > > + * Allow platform reduce the interrupt load on the CPU during SPI > > > + * transfers. We do not target maximum performanc

Re: [PATCH v5] spi: Add PPC4xx SPI driver

2009-01-05 Thread Stefan Roese
On Saturday 27 December 2008, David Brownell wrote: > On Tuesday 25 November 2008, Stefan Roese wrote: > > Changes in v5: > > - Don't call setupxfer() from setup() so that the baudrate etc > > won't get changed while another transfer is active, as suggested > > by David Brownell. > > Better, bu

Re: [PATCH v5] spi: Add PPC4xx SPI driver

2008-12-27 Thread Stephen Rothwell
Hi David, Stefan, On Sat, 27 Dec 2008 11:32:25 -0800 David Brownell wrote: > > Also: > > > +static struct of_platform_driver spi_ppc4xx_of_driver = { > > +   .owner = THIS_MODULE, > > +   .name = DRIVER_NAME, > > I'd hope the PPC folk eliminate this duplication soonish. > Those fields a

Re: [PATCH v5] spi: Add PPC4xx SPI driver

2008-12-27 Thread David Brownell
Also: > +static struct of_platform_driver spi_ppc4xx_of_driver = { > +   .owner = THIS_MODULE, > +   .name = DRIVER_NAME, I'd hope the PPC folk eliminate this duplication soonish. Those fields are obvious duplicates of the driver model fields... > +   .match_table = spi_ppc4xx_of_ma

Re: [PATCH v5] spi: Add PPC4xx SPI driver

2008-12-27 Thread David Brownell
On Tuesday 25 November 2008, Stefan Roese wrote: > Changes in v5: > - Don't call setupxfer() from setup() so that the baudrate etc > won't get changed while another transfer is active, as suggested > by David Brownell. Better, but this still doesn't seem quite right: > +static int spi_ppc4xx

Re: [PATCH v5] spi: Add PPC4xx SPI driver

2008-12-09 Thread Steven A. Falco
Steven A. Falco wrote: > Stefan Roese wrote: >> This adds a SPI driver for the SPI controller found in the IBM/AMCC >> 4xx PowerPC's. >> >> Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> >> Signed-off-by: Wolfgang Ocker <[EMAIL PROTECTED]> >> Acked-by: Josh Boyer <[EMAIL PROTECTED]> >> --- > > How

Re: [PATCH v5] spi: Add PPC4xx SPI driver

2008-12-09 Thread Steven A. Falco
Stefan Roese wrote: > This adds a SPI driver for the SPI controller found in the IBM/AMCC > 4xx PowerPC's. > > Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> > Signed-off-by: Wolfgang Ocker <[EMAIL PROTECTED]> > Acked-by: Josh Boyer <[EMAIL PROTECTED]> > --- I have a question as to how to use th

[PATCH v5] spi: Add PPC4xx SPI driver

2008-11-25 Thread Stefan Roese
This adds a SPI driver for the SPI controller found in the IBM/AMCC 4xx PowerPC's. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Wolfgang Ocker <[EMAIL PROTECTED]> Acked-by: Josh Boyer <[EMAIL PROTECTED]> --- Changes in v5: - Don't call setupxfer() from setup() so that the baudrat