RE: [PATCH v5] ppc44x:PHY fixup for USB on canyonlands board

2010-12-12 Thread Rupjyoti Sarmah
>This can fail if you boot a new kernel on a board with an old FDT that lacks the gpio node. Calling of_iomap with a NULL np seems like it would work without crashing anything, so maybe that's not a huge issue. >>+ vaddr = of_iomap(np, 0); >>+ if (!vaddr) { >>+ printk(KERN_CRI

Re: [PATCH v5] ppc44x:PHY fixup for USB on canyonlands board

2010-12-10 Thread Josh Boyer
On Thu, Dec 09, 2010 at 09:54:01AM +0530, Rupjyoti Sarmah wrote: A few error path issues, plus one leak in the good case. I'll wait to see if there are any more comments for a couple of days. >+static int __init ppc460ex_canyonlands_fixup(void) >+{ >+ u8 __iomem *bcsr ; >+ void __iomem

[PATCH v5] ppc44x:PHY fixup for USB on canyonlands board

2010-12-08 Thread Rupjyoti Sarmah
This fix is a reset for USB PHY that requires some amount of time for power to be stable on Canyonlands. Signed-off-by: Rupjyoti Sarmah --- changes from previous version: -- dts node correction, removed the address and size parameters -- Kconfig file updated removing dependency on PPC44x_SIMPLE