RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-28 Thread Tang Yuantian-B29983
H v5] powerpc/mpc85xx: Update the clock nodes in device > tree > > On Sun, 2013-10-20 at 21:55 -0500, Tang Yuantian-B29983 wrote: > > I didn't see how your suggestion is a better matching. > > > > OSC > PLL1 > mux > CPU > > |

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-28 Thread Scott Wood
On Sun, 2013-10-20 at 21:55 -0500, Tang Yuantian-B29983 wrote: > I didn't see how your suggestion is a better matching. > > OSC > PLL1 > mux > CPU > | | > |--> PLL2 --| > > As your suggestion, the clock tree looks like the above. > In this case,

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-27 Thread Tang Yuantian-B29983
> > +1. Clock Block Binding > > + > > +Required properties: > > +- compatible: Should include one or more of the following: > > + - "fsl,-clockgen": for chip specific clock block > > + - "fsl,qoriq-clockgen-[1,2].x": for chassis 1.x and 2.x clock > > +- reg: Offset and length of the clock regis

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-25 Thread Grant Likely
On Wed, 9 Oct 2013 14:38:24 +0800, wrote: > From: Tang Yuantian > > The following SoCs will be affected: p2041, p3041, p4080, > p5020, p5040, b4420, b4860, t4240 > > Signed-off-by: Tang Yuantian > Signed-off-by: Li Yang > --- > v5: > - refine the binding document > - update the co

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-21 Thread Tang Yuantian-B29983
; Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device > tree > > On Sat, Oct 12, 2013 at 04:40:06AM +0100, Tang Yuantian-B29983 wrote: > > Thanks for your review. > > > > > > > > > > > > > > > +- reg: Offset and lengt

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-21 Thread Mark Rutland
On Sat, Oct 12, 2013 at 04:40:06AM +0100, Tang Yuantian-B29983 wrote: > Thanks for your review. > > > > > > > > > > > +- reg: Offset and length of the clock register set > > > > > +- clock-frequency: Indicates input clock frequency of clock block. > > > > > + Will be set by u-boot > > > > >

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-20 Thread Tang Yuantian-B29983
> > > > > > > > > > It's still selecting from multiple PLLs. > > > > > > > > > > > I don't know whether "divider" module exists or not. If it > > > > > > exists, it should be part of PLL or between PLL and MUX. > > > > > > wherever it was, the > > > > > device tree binding is appropriate. > > > > >

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-18 Thread Scott Wood
On Thu, 2013-10-17 at 21:06 -0500, Tang Yuantian-B29983 wrote: > > On Wed, 2013-10-16 at 21:08 -0500, Tang Yuantian-B29983 wrote: > > > > > > That shows the dividers as being somewhere in between the PLL > > > > > > and the > > > > MUX. > > > > > > The MUX is where the divider is selected. There's

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-17 Thread Tang Yuantian-B29983
> On Wed, 2013-10-16 at 21:08 -0500, Tang Yuantian-B29983 wrote: > > > > > That shows the dividers as being somewhere in between the PLL > > > > > and the > > > MUX. > > > > > The MUX is where the divider is selected. There's nothing in > > > > > the PLL's programming interface that relates to the

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-17 Thread Scott Wood
On Wed, 2013-10-16 at 21:08 -0500, Tang Yuantian-B29983 wrote: > > > > That shows the dividers as being somewhere in between the PLL and the > > MUX. > > > > The MUX is where the divider is selected. There's nothing in the > > > > PLL's programming interface that relates to the dividers. As such

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-16 Thread Tang Yuantian-B29983
> > > That shows the dividers as being somewhere in between the PLL and the > MUX. > > > The MUX is where the divider is selected. There's nothing in the > > > PLL's programming interface that relates to the dividers. As such > > > it's simpler to model it as being part of the MUX. > > > > > > -S

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-16 Thread Scott Wood
On Tue, 2013-10-15 at 21:57 -0500, Tang Yuantian-B29983 wrote: > > > > > > > > > > > The device tree makes that quite clear. > > > > > > > > You chose to model it that way in the device tree; that doesn't make > > > > it clear that the hardware works that way or that it's a good way to > > > > mode

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-15 Thread Tang Yuantian-B29983
> > > > > > > > > The device tree makes that quite clear. > > > > > > You chose to model it that way in the device tree; that doesn't make > > > it clear that the hardware works that way or that it's a good way to > > > model it. > > > > > > > Each PLL has several output which MUX node can take fro

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-15 Thread Scott Wood
pc-dev@lists.ozlabs.org; Li Yang-Leo-R58472 > > Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device > > tree > > > > On Fri, 2013-10-11 at 21:52 -0500, Tang Yuantian-B29983 wrote: > > > Thanks for your review. > > > > > > >

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-14 Thread Tang Yuantian-B29983
t; To: Mark Rutland > > > Cc: Tang Yuantian-B29983; devicet...@vger.kernel.org; linuxppc- > > > d...@lists.ozlabs.org; Li Yang-Leo-R58472 > > > Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in > > > device tree > > > > > > I'm n

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-14 Thread Scott Wood
linuxppc- > > d...@lists.ozlabs.org; Li Yang-Leo-R58472 > > Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device > > tree > > > > I'm not sure I understand the "_0"/"_1" part, though. Doesn't each PLL > > just

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Tang Yuantian-B29983
Thanks for your review. > > > > > > > +- reg: Offset and length of the clock register set > > > > +- clock-frequency: Indicates input clock frequency of clock block. > > > > + Will be set by u-boot > > > > > > Why does the fact this is set by u-boot matter to the binding? > > > > > OK, I wi

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Tang Yuantian-B29983
Thanks for your review. > -Original Message- > From: Wood Scott-B07421 > Sent: 2013年10月12日 星期六 3:08 > To: Tang Yuantian-B29983 > Cc: ga...@kernel.crashing.org; devicet...@vger.kernel.org; linuxppc- > d...@lists.ozlabs.org > Subject: Re: [PATCH v5] powerpc/mpc85xx: U

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Tang Yuantian-B29983
gt; -Original Message- > > > > From: Mark Rutland [mailto:mark.rutl...@arm.com] > > > > Sent: 2013年10月10日 星期四 18:04 > > > > To: Tang Yuantian-B29983 > > > > Cc: ga...@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org; > > > > device

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Scott Wood
On Wed, 2013-10-09 at 14:38 +0800, yuantian.t...@freescale.com wrote: > From: Tang Yuantian +/ { > + clockgen: global-utilities@e1000 { > + compatible = "fsl,p5020-clockgen", "fsl,qoriq-clockgen-1.0"; > + reg = <0xe1000 0x1000>; > + clock-frequency = <0>; >

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Scott Wood
..@arm.com] > > > Sent: 2013年10月10日 星期四 18:04 > > > To: Tang Yuantian-B29983 > > > Cc: ga...@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org; > > > devicet...@vger.kernel.org; Li Yang-Leo-R58472 > > > Subject: Re: [PATCH v5] powerpc/mpc85xx: Update

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-11 Thread Mark Rutland
> > Cc: ga...@kernel.crashing.org; linuxppc-dev@lists.ozlabs.org; > > devicet...@vger.kernel.org; Li Yang-Leo-R58472 > > Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device > > tree > > > > On Wed, Oct 09, 2013 at 07:38:24AM +0

RE: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-10 Thread Tang Yuantian-B29983
Li Yang-Leo-R58472 > Subject: Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device > tree > > On Wed, Oct 09, 2013 at 07:38:24AM +0100, yuantian.t...@freescale.com > wrote: > > From: Tang Yuantian > > > > The following SoCs will be affected: p2041,

Re: [PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-10 Thread Mark Rutland
On Wed, Oct 09, 2013 at 07:38:24AM +0100, yuantian.t...@freescale.com wrote: > From: Tang Yuantian > > The following SoCs will be affected: p2041, p3041, p4080, > p5020, p5040, b4420, b4860, t4240 > > Signed-off-by: Tang Yuantian > Signed-off-by: Li Yang > --- > v5: > - refine the bindin

[PATCH v5] powerpc/mpc85xx: Update the clock nodes in device tree

2013-10-08 Thread Yuantian.Tang
From: Tang Yuantian The following SoCs will be affected: p2041, p3041, p4080, p5020, p5040, b4420, b4860, t4240 Signed-off-by: Tang Yuantian Signed-off-by: Li Yang --- v5: - refine the binding document - update the compatible string v4: - add binding document -