Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-07 Thread Grant Erickson
On 7/7/08 12:50 PM, Valentine Barshak wrote: > Grant Erickson wrote: > > > >> -reg = ; >> +reg = ; > > Should be reg = > > > >> -reg = ; >> +reg = ; > > Should be reg = Good catch; amended patch forthcoming. Regards, Grant _

Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-07 Thread Valentine Barshak
Grant Erickson wrote: index 48c9a6e..799592d 100644 --- a/arch/powerpc/boot/dts/kilauea.dts +++ b/arch/powerpc/boot/dts/kilauea.dts @@ -205,7 +205,7 @@ EMAC0: [EMAIL PROTECTED] { linux,network-index = <0>;

Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-07 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: Hi Jeff ! If you are ok with this patch, I'll take it through the powerpc tree since it changes all those device tree files. ACK ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo

Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-06 Thread Benjamin Herrenschmidt
On Mon, 2008-07-07 at 08:29 +0200, Stefan Roese wrote: > > Did you have a chance to do a bit of regression testing "just in case" ? > > No, not yet. I'll try to do some tests this week. Thanks ! Cheers, Ben. ___ Linuxppc-dev mailing list Linuxppc-dev

Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-06 Thread Stefan Roese
On Monday 07 July 2008, Benjamin Herrenschmidt wrote: > On Mon, 2008-07-07 at 07:58 +0200, Stefan Roese wrote: > > On Monday 07 July 2008, Grant Erickson wrote: > > > Various instances of the EMAC core have varying: 1) number of address > > > match slots, 2) width of the registers for handling addr

Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-06 Thread Benjamin Herrenschmidt
Hi Jeff ! If you are ok with this patch, I'll take it through the powerpc tree since it changes all those device tree files. Cheers, Ben. On Sun, 2008-07-06 at 16:30 -0700, Grant Erickson wrote: > Various instances of the EMAC core have varying: 1) number of address > match slots, 2) width of t

Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-06 Thread Benjamin Herrenschmidt
On Mon, 2008-07-07 at 07:58 +0200, Stefan Roese wrote: > On Monday 07 July 2008, Grant Erickson wrote: > > Various instances of the EMAC core have varying: 1) number of address > > match slots, 2) width of the registers for handling address match slots, > > 3) number of registers for handling addre

Re: [PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-06 Thread Stefan Roese
On Monday 07 July 2008, Grant Erickson wrote: > Various instances of the EMAC core have varying: 1) number of address > match slots, 2) width of the registers for handling address match slots, > 3) number of registers for handling address match slots and 4) base > offset for those registers. > S

[PATCH v5] ibm_newemac: Parameterize EMAC Multicast Match Handling

2008-07-06 Thread Grant Erickson
Various instances of the EMAC core have varying: 1) number of address match slots, 2) width of the registers for handling address match slots, 3) number of registers for handling address match slots and 4) base offset for those registers. As the driver stands today, it assumes that all EMACs ha