Re: [PATCH v4 net-next] fix unsafe set_memory_rw from softirq

2013-10-07 Thread David Miller
From: Eric Dumazet Date: Sun, 06 Oct 2013 09:56:32 -0700 > On Fri, 2013-10-04 at 00:14 -0700, Alexei Starovoitov wrote: >> on x86 system with net.core.bpf_jit_enable = 1 > >> cannot reuse jited filter memory, since it's readonly, >> so use original bpf insns memory to hold work_struct >> >> def

Re: [PATCH v4 net-next] fix unsafe set_memory_rw from softirq

2013-10-06 Thread Eric Dumazet
On Fri, 2013-10-04 at 00:14 -0700, Alexei Starovoitov wrote: > on x86 system with net.core.bpf_jit_enable = 1 > cannot reuse jited filter memory, since it's readonly, > so use original bpf insns memory to hold work_struct > > defer kfree of sk_filter until jit completed freeing > > tested on x86

[PATCH v4 net-next] fix unsafe set_memory_rw from softirq

2013-10-04 Thread Alexei Starovoitov
on x86 system with net.core.bpf_jit_enable = 1 sudo tcpdump -i eth1 'tcp port 22' causes the warning: [ 56.766097] Possible unsafe locking scenario: [ 56.766097] [ 56.780146]CPU0 [ 56.786807] [ 56.793188] lock(&(&vb->lock)->rlock); [ 56.799593] [ 56.805889]