Re: [PATCH v4 2/2] tty: add TIOCGPTPEER ioctl

2017-06-09 Thread Aleksa Sarai
When opening the slave end of a PTY, it is not possible for userspace to safely ensure that /dev/pts/$num is actually a slave (in cases where the mount namespace in which devpts was mounted is controlled by an untrusted process). In addition, there are several unresolvable race conditions if users

Re: [PATCH v4 2/2] tty: add TIOCGPTPEER ioctl

2017-06-09 Thread Greg Kroah-Hartman
On Fri, Jun 09, 2017 at 07:50:43PM +1000, Aleksa Sarai wrote: > > > When opening the slave end of a PTY, it is not possible for userspace to > > > safely ensure that /dev/pts/$num is actually a slave (in cases where the > > > mount namespace in which devpts was mounted is controlled by an > > > unt

Re: [PATCH v4 2/2] tty: add TIOCGPTPEER ioctl

2017-06-09 Thread Aleksa Sarai
When opening the slave end of a PTY, it is not possible for userspace to safely ensure that /dev/pts/$num is actually a slave (in cases where the mount namespace in which devpts was mounted is controlled by an untrusted process). In addition, there are several unresolvable race conditions if users

Re: [PATCH v4 2/2] tty: add TIOCGPTPEER ioctl

2017-06-09 Thread Greg Kroah-Hartman
On Sun, Jun 04, 2017 at 12:15:15AM +1000, Aleksa Sarai wrote: > When opening the slave end of a PTY, it is not possible for userspace to > safely ensure that /dev/pts/$num is actually a slave (in cases where the > mount namespace in which devpts was mounted is controlled by an > untrusted process).

[PATCH v4 2/2] tty: add TIOCGPTPEER ioctl

2017-06-03 Thread Aleksa Sarai
When opening the slave end of a PTY, it is not possible for userspace to safely ensure that /dev/pts/$num is actually a slave (in cases where the mount namespace in which devpts was mounted is controlled by an untrusted process). In addition, there are several unresolvable race conditions if usersp