I agree with all the below and will address in v5.
Mikey
On Tue, 2019-05-28 at 23:28 -0700, Christoph Hellwig wrote:
> > +config PPC_DAWR
> > + bool
> > + default n
>
> "default n" is the default default. No need to write this line.
>
> > +++ b/arch/powerpc/kernel/dawr.c
> > @@ -0,0 +1,100
> +config PPC_DAWR
> + bool
> + default n
"default n" is the default default. No need to write this line.
> +++ b/arch/powerpc/kernel/dawr.c
> @@ -0,0 +1,100 @@
> +// SPDX-License-Identifier: GPL-2.0+
> +//
> +// DAWR infrastructure
> +//
> +// Copyright 2019, Michael Neuling, IBM Corpor
If you compile with KVM but without CONFIG_HAVE_HW_BREAKPOINT you fail
at linking with:
arch/powerpc/kvm/book3s_hv_rmhandlers.o:(.text+0x708): undefined reference to
`dawr_force_enable'
This was caused by commit c1fe190c0672 ("powerpc: Add force enable of
DAWR on P9 option").
This moves a bunc
