Re: [PATCH v4 11/31] net: can: mscan: improve clock API use

2013-08-08 Thread Gerhard Sittig
On Wed, Aug 07, 2013 at 09:28 +0200, Marc Kleine-Budde wrote: > > On 08/06/2013 10:43 PM, Gerhard Sittig wrote: > > [ ... ] > > diff --git a/drivers/net/can/mscan/mscan.c b/drivers/net/can/mscan/mscan.c > > index e6b4095..4f998f5 100644 > > --- a/drivers/net/can/mscan/mscan.c > > +++ b/drivers/net

Re: [PATCH v4 11/31] net: can: mscan: improve clock API use

2013-08-07 Thread Marc Kleine-Budde
On 08/07/2013 09:30 AM, Marc Kleine-Budde wrote: > On 08/06/2013 10:43 PM, Gerhard Sittig wrote: >> the .get_clock() callback is run from probe() and might allocate >> resources, introduce a .put_clock() callback that is run from remove() >> to undo any allocation activities > > AFAICS With this p

Re: [PATCH v4 11/31] net: can: mscan: improve clock API use

2013-08-07 Thread Marc Kleine-Budde
On 08/06/2013 10:43 PM, Gerhard Sittig wrote: > the .get_clock() callback is run from probe() and might allocate > resources, introduce a .put_clock() callback that is run from remove() > to undo any allocation activities AFAICS With this patch put_clock() is still a no-op, is there a patch which

Re: [PATCH v4 11/31] net: can: mscan: improve clock API use

2013-08-07 Thread Marc Kleine-Budde
On 08/06/2013 10:43 PM, Gerhard Sittig wrote: > the .get_clock() callback is run from probe() and might allocate > resources, introduce a .put_clock() callback that is run from remove() > to undo any allocation activities > > prepare and enable the clocks in open(), disable and unprepare the > clo

[PATCH v4 11/31] net: can: mscan: improve clock API use

2013-08-06 Thread Gerhard Sittig
the .get_clock() callback is run from probe() and might allocate resources, introduce a .put_clock() callback that is run from remove() to undo any allocation activities prepare and enable the clocks in open(), disable and unprepare the clocks in close() if clocks were acquired during probe(), to