Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Grant Likely wrote: > On Wed, Feb 10, 2010 at 3:53 AM, Wolfgang Grandegger > wrote: >> Stephen Rothwell wrote: >>> Hi Wolfgang, >>> >>> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger >>> wrote: > __devinitdata goes at the end, immediately before the '='. Ditto > throughout the

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Grant Likely
On Wed, Feb 10, 2010 at 3:53 AM, Wolfgang Grandegger wrote: > Stephen Rothwell wrote: >> Hi Wolfgang, >> >> On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger >> wrote: __devinitdata goes at the end, immediately before the '='.  Ditto throughout the file. >>> This made a differenc

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Stephen Rothwell wrote: > Hi Wolfgang, > > On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger > wrote: >>> __devinitdata goes at the end, immediately before the '='. Ditto >>> throughout the file. >> This made a difference and revealed section mismatches. "const" seems to >> be incompatible

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Stephen Rothwell
Hi Wolfgang, On Wed, 10 Feb 2010 11:09:25 +0100 Wolfgang Grandegger wrote: > > > __devinitdata goes at the end, immediately before the '='. Ditto > > throughout the file. > > This made a difference and revealed section mismatches. "const" seems to > be incompatible with "__devinitdata". Maybe

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-10 Thread Wolfgang Grandegger
Grant Likely wrote: > On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger > wrote: >> From: Wolfgang Grandegger >> >> "__devinit[data]" has not yet been used for all initialization functions >> and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has >> been renamed to "mpc_i2c_

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-02-09 Thread Grant Likely
On Thu, Jan 28, 2010 at 6:25 AM, Wolfgang Grandegger wrote: > From: Wolfgang Grandegger > > "__devinit[data]" has not yet been used for all initialization functions > and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has > been renamed to "mpc_i2c_data", which is even the bett

Re: [PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-29 Thread Wolfram Sang
On Thu, Jan 28, 2010 at 02:25:39PM +0100, Wolfgang Grandegger wrote: > From: Wolfgang Grandegger > > "__devinit[data]" has not yet been used for all initialization functions > and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has > been renamed to "mpc_i2c_data", which is even

[PATCH v4 1/3] i2c-mpc: use __devinit[data] for initialization functions and data

2010-01-28 Thread Wolfgang Grandegger
From: Wolfgang Grandegger "__devinit[data]" has not yet been used for all initialization functions and data. To avoid truncating lines, the struct "mpc_i2c_match_data" has been renamed to "mpc_i2c_data", which is even the better name. Signed-off-by: Wolfgang Grandegger --- drivers/i2c/busses/i