Re: [PATCH v4 06/11] cxl: Refactor adaptor init/teardown

2015-08-14 Thread Daniel Axtens
> These seem a bit odd here (though perfectly harmless) - not sure these > need to be done again on recovery (but maybe I'm wrong?) - seems more > like something that should be done early in cxl_init_adapter? > I was really trying to get init to do _only_ things that are once-off operations. As s

Re: [PATCH v4 06/11] cxl: Refactor adaptor init/teardown

2015-08-13 Thread Ian Munsie
Excerpts from Daniel Axtens's message of 2015-08-13 14:11:24 +1000: > +/* This should contain *only* operations that can safely be done in > + * both creation and recovery. > + */ > +static int cxl_configure_adapter(struct cxl *adapter, struct pci_dev *dev) > { > -struct cxl *adapter; > -b

[PATCH v4 06/11] cxl: Refactor adaptor init/teardown

2015-08-12 Thread Daniel Axtens
Some aspects of initialisation are done only once in the lifetime of an adapter: for example, allocating memory for the adapter, allocating the adapter number, or setting up sysfs/debugfs files. However, we may want to be able to do some parts of the initialisation multiple times: for example, in