Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-13 Thread Geert Uytterhoeven
On Fri, Dec 10, 2021 at 8:14 PM Rafael J. Wysocki wrote: > On Fri, Dec 10, 2021 at 8:04 PM Dmitry Osipenko wrote: > > 10.12.2021 21:27, Rafael J. Wysocki пишет: > > > On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko wrote: > > >> 29.11.2021 03:26, Michał Mirosław пишет: > > >>> On Mon, Nov 29, 2

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-12 Thread Dmitry Osipenko
10.12.2021 22:44, Dmitry Osipenko пишет: > 10.12.2021 22:42, Dmitry Osipenko пишет: > ... There is no strong requirement for priorities to be unique, the reboot.c code will work properly. >>> >>> In which case adding the WARN() is not appropriate IMV. >>> >>> Also I've looked at the exist

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-12 Thread Dmitry Osipenko
10.12.2021 22:42, Dmitry Osipenko пишет: ... >>> There is no strong requirement for priorities to be unique, the reboot.c >>> code will work properly. >> >> In which case adding the WARN() is not appropriate IMV. >> >> Also I've looked at the existing code and at least in some cases the >> order in

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-12 Thread Dmitry Osipenko
10.12.2021 22:14, Rafael J. Wysocki пишет: > On Fri, Dec 10, 2021 at 8:04 PM Dmitry Osipenko wrote: >> >> 10.12.2021 21:27, Rafael J. Wysocki пишет: >>> On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko wrote: 29.11.2021 03:26, Michał Mirosław пишет: > On Mon, Nov 29, 2021 at 12:06:1

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-12 Thread Rafael J. Wysocki
On Fri, Dec 10, 2021 at 8:04 PM Dmitry Osipenko wrote: > > 10.12.2021 21:27, Rafael J. Wysocki пишет: > > On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko wrote: > >> > >> 29.11.2021 03:26, Michał Mirosław пишет: > >>> On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote: > 28.11.

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-12 Thread Dmitry Osipenko
10.12.2021 21:27, Rafael J. Wysocki пишет: > On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko wrote: >> >> 29.11.2021 03:26, Michał Mirosław пишет: >>> On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote: 28.11.2021 03:28, Michał Mirosław пишет: > On Fri, Nov 26, 2021 at 09:00

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-12-12 Thread Rafael J. Wysocki
On Mon, Nov 29, 2021 at 12:34 PM Dmitry Osipenko wrote: > > 29.11.2021 03:26, Michał Mirosław пишет: > > On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote: > >> 28.11.2021 03:28, Michał Mirosław пишет: > >>> On Fri, Nov 26, 2021 at 09:00:41PM +0300, Dmitry Osipenko wrote: > Add

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-11-29 Thread Dmitry Osipenko
29.11.2021 03:26, Michał Mirosław пишет: > On Mon, Nov 29, 2021 at 12:06:19AM +0300, Dmitry Osipenko wrote: >> 28.11.2021 03:28, Michał Mirosław пишет: >>> On Fri, Nov 26, 2021 at 09:00:41PM +0300, Dmitry Osipenko wrote: Add sanity check which ensures that there are no two restart handlers >>>

Re: [PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-11-28 Thread Dmitry Osipenko
28.11.2021 03:28, Michał Mirosław пишет: > On Fri, Nov 26, 2021 at 09:00:41PM +0300, Dmitry Osipenko wrote: >> Add sanity check which ensures that there are no two restart handlers >> registered with the same priority. Normally it's a direct sign of a >> problem if two handlers use the same priorit

[PATCH v4 05/25] reboot: Warn if restart handler has duplicated priority

2021-11-26 Thread Dmitry Osipenko
Add sanity check which ensures that there are no two restart handlers registered with the same priority. Normally it's a direct sign of a problem if two handlers use the same priority. Signed-off-by: Dmitry Osipenko --- kernel/reboot.c | 15 ++- 1 file changed, 14 insertions(+), 1 de