Re: [PATCH v4 0/7] mm/mprotect: Fix dax puds

2024-08-08 Thread Peter Xu
On Wed, Aug 07, 2024 at 02:44:54PM -0700, Andrew Morton wrote: > On Wed, 7 Aug 2024 17:34:10 -0400 Peter Xu wrote: > > > The problem is mprotect() will skip the dax 1G PUD while it shouldn't; > > meanwhile it'll dump some bad PUD in dmesg. Both of them look like (corner > > case) bugs to me.. wh

Re: [PATCH v4 0/7] mm/mprotect: Fix dax puds

2024-08-07 Thread Peter Xu
On Wed, Aug 07, 2024 at 02:23:16PM -0700, Andrew Morton wrote: > On Wed, 7 Aug 2024 15:48:04 -0400 Peter Xu wrote: > > > > > Tests > > = > > > > What I did test: > > > > - cross-build tests that I normally cover [1] > > > > - smoke tested on x86_64 the simplest program [2] on dev_dax 1G

Re: [PATCH v4 0/7] mm/mprotect: Fix dax puds

2024-08-07 Thread Andrew Morton
On Wed, 7 Aug 2024 17:34:10 -0400 Peter Xu wrote: > The problem is mprotect() will skip the dax 1G PUD while it shouldn't; > meanwhile it'll dump some bad PUD in dmesg. Both of them look like (corner > case) bugs to me.. where: > > - skipping the 1G pud means mprotect() will succeed even if t

Re: [PATCH v4 0/7] mm/mprotect: Fix dax puds

2024-08-07 Thread Peter Xu
On Wed, Aug 07, 2024 at 02:17:03PM -0700, Andrew Morton wrote: > On Wed, 7 Aug 2024 15:48:04 -0400 Peter Xu wrote: > > > > > Dax supports pud pages for a while, but mprotect on puds was missing since > > the start. This series tries to fix that by providing pud handling in > > mprotect(). The

Re: [PATCH v4 0/7] mm/mprotect: Fix dax puds

2024-08-07 Thread Andrew Morton
On Wed, 7 Aug 2024 15:48:04 -0400 Peter Xu wrote: > > Tests > = > > What I did test: > > - cross-build tests that I normally cover [1] > > - smoke tested on x86_64 the simplest program [2] on dev_dax 1G PUD > mprotect() using QEMU's nvdimm emulations [3] and ndctl to create > namespa

Re: [PATCH v4 0/7] mm/mprotect: Fix dax puds

2024-08-07 Thread Andrew Morton
On Wed, 7 Aug 2024 15:48:04 -0400 Peter Xu wrote: > > Dax supports pud pages for a while, but mprotect on puds was missing since > the start. This series tries to fix that by providing pud handling in > mprotect(). The goal is to add more types of pud mappings like hugetlb or > pfnmaps. This

[PATCH v4 0/7] mm/mprotect: Fix dax puds

2024-08-07 Thread Peter Xu
[Based on mm-unstable, commit 98808d08fc0f, Aug 7th] v4: - Added tags - Dropped patch "mm/mprotect: Remove NUMA_HUGE_PTE_UPDATES" [DavidH] - Touched up comment in pgtable_split_needed() [James] v1: https://lore.kernel.org/r/20240621142504.1940209-1-pet...@redhat.com v2: https://lore.kernel.org/r/