Re: [PATCH v4] PCI: Unify ECAM constants in native PCI Express drivers

2020-11-20 Thread Bjorn Helgaas
On Mon, Oct 05, 2020 at 12:38:05AM +, Krzysztof Wilczyński wrote: > Unify ECAM-related constants into a single set of standard constants > defining memory address shift values for the byte-level address that can > be used when accessing the PCI Express Configuration Space, and then > move nativ

Re: [PATCH v4] PCI: Unify ECAM constants in native PCI Express drivers

2020-11-14 Thread Krzysztof Wilczyński
On 20-10-04 19:53:06, Florian Fainelli wrote: Hi Florian, Sorry for taking a long time to get back to you. [...] > This appears to be correct, so: > > Acked-by: Florian Fainelli Thank you! > however, I would have defined a couple of additional helper macros and do: > > idx = PCIE_ECA

Re: [PATCH v4] PCI: Unify ECAM constants in native PCI Express drivers

2020-10-04 Thread Florian Fainelli
On 10/4/2020 5:38 PM, Krzysztof Wilczyński wrote: Unify ECAM-related constants into a single set of standard constants defining memory address shift values for the byte-level address that can be used when accessing the PCI Express Configuration Space, and then move native PCI Express controlle

[PATCH v4] PCI: Unify ECAM constants in native PCI Express drivers

2020-10-04 Thread Krzysztof Wilczyński
Unify ECAM-related constants into a single set of standard constants defining memory address shift values for the byte-level address that can be used when accessing the PCI Express Configuration Space, and then move native PCI Express controller drivers to use newly introduced definitions retiring