> > > >
> > > > Each patch having a commit message that explains why a change is being
> > > > made is the expectation. It is especially useful to explain the why
> > > > here, since it is not just a mechanical conversion of pr_debug()s as the
&
t a mechanical conversion of pr_debug()s as the
> > > commit message suggests.
> >
> > Sounds reasonable. I rephrase the patch 3 log as below, do you think
> > it's OK to you?
>
> Yes, but with one comment.
>
> >
> > I will also adjust patch
ation. It is especially useful to explain the why
> > here, since it is not just a mechanical conversion of pr_debug()s as the
> > commit message suggests.
>
> Sounds reasonable. I rephrase the patch 3 log as below, do you think
> it's OK to you?
Yes, but with one
the patch 3 log as below, do you think
it's OK to you?
I will also adjust patch logs on other ARCH once this one is done.
Thanks.
=
Subject: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if
required
Then when specifying '-d' for kexec_file
On Mon, Dec 04, 2023 at 11:38:05PM +0800, Baoquan He wrote:
> On 12/01/23 at 10:38am, Conor Dooley wrote:
> > On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote:
> >
> > $subject has a typo in the arch bit :)
>
> Indeed, will fix if need report. Thanks for careful checking.
>
> >
> > >
On 12/01/23 at 10:38am, Conor Dooley wrote:
> On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote:
>
> $subject has a typo in the arch bit :)
Indeed, will fix if need report. Thanks for careful checking.
>
> > Replace pr_debug() with the newly added kexec_dprintk() in kexec_file
> > load
On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote:
$subject has a typo in the arch bit :)
> Replace pr_debug() with the newly added kexec_dprintk() in kexec_file
> loading related codes.
Commit messages should be understandable in isolation, but this only
explains (part of) what is obvi
Replace pr_debug() with the newly added kexec_dprintk() in kexec_file
loading related codes.
And also remove kexec_image_info() because the content has been printed
out in generic code.
Signed-off-by: Baoquan He
---
arch/riscv/kernel/elf_kexec.c | 11 ++-
arch/riscv/kernel/machine_k