Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-12 Thread Baoquan He
> > > > > > > > Each patch having a commit message that explains why a change is being > > > > made is the expectation. It is especially useful to explain the why > > > > here, since it is not just a mechanical conversion of pr_debug()s as the &

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-06 Thread Baoquan He
t a mechanical conversion of pr_debug()s as the > > > commit message suggests. > > > > Sounds reasonable. I rephrase the patch 3 log as below, do you think > > it's OK to you? > > Yes, but with one comment. > > > > > I will also adjust patch

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-06 Thread Conor Dooley
ation. It is especially useful to explain the why > > here, since it is not just a mechanical conversion of pr_debug()s as the > > commit message suggests. > > Sounds reasonable. I rephrase the patch 3 log as below, do you think > it's OK to you? Yes, but with one

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-06 Thread Baoquan He
the patch 3 log as below, do you think it's OK to you? I will also adjust patch logs on other ARCH once this one is done. Thanks. = Subject: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required Then when specifying '-d' for kexec_file

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-04 Thread Conor Dooley
On Mon, Dec 04, 2023 at 11:38:05PM +0800, Baoquan He wrote: > On 12/01/23 at 10:38am, Conor Dooley wrote: > > On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote: > > > > $subject has a typo in the arch bit :) > > Indeed, will fix if need report. Thanks for careful checking. > > > > > >

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-04 Thread Baoquan He
On 12/01/23 at 10:38am, Conor Dooley wrote: > On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote: > > $subject has a typo in the arch bit :) Indeed, will fix if need report. Thanks for careful checking. > > > Replace pr_debug() with the newly added kexec_dprintk() in kexec_file > > load

Re: [PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-12-01 Thread Conor Dooley
On Thu, Nov 30, 2023 at 10:39:53AM +0800, Baoquan He wrote: $subject has a typo in the arch bit :) > Replace pr_debug() with the newly added kexec_dprintk() in kexec_file > loading related codes. Commit messages should be understandable in isolation, but this only explains (part of) what is obvi

[PATCH v3 5/7] kexec_file, ricv: print out debugging message if required

2023-11-29 Thread Baoquan He
Replace pr_debug() with the newly added kexec_dprintk() in kexec_file loading related codes. And also remove kexec_image_info() because the content has been printed out in generic code. Signed-off-by: Baoquan He --- arch/riscv/kernel/elf_kexec.c | 11 ++- arch/riscv/kernel/machine_k