Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-09 Thread Dave Martin
Hi, On Thu, Jan 09, 2025 at 02:29:19PM +0900, Akihiko Odaki wrote: > On 2025/01/08 22:50, Dave Martin wrote: > > On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: > > > On 2025/01/08 1:17, Dave Martin wrote: > > > > Hi, > > > > > > > > On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihik

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-08 Thread Akihiko Odaki
On 2025/01/08 22:50, Dave Martin wrote: On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: On 2025/01/08 1:17, Dave Martin wrote: Hi, On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: Use note name macros to match with the userspace's expectation. Signed-off-by: Akih

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-08 Thread Dave Martin
On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: > On 2025/01/08 1:17, Dave Martin wrote: > > Hi, > > > > On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: > > > Use note name macros to match with the userspace's expectation. > > > > > > Signed-off-by: Akihiko Odaki >

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-08 Thread Heiko Carstens
On Wed, Jan 08, 2025 at 01:53:51PM +0900, Akihiko Odaki wrote: > On 2025/01/08 1:17, Dave Martin wrote: > > > +#define NT_INIT(buf, type, desc) \ > > > + (nt_init_name((buf), NT_ ## type, &(desc), sizeof(desc), NN_ ## type)) > > > > Nit: this macro name clashes with the naming scheme in elf.h. > >

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-07 Thread Akihiko Odaki
On 2025/01/08 1:17, Dave Martin wrote: Hi, On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: Use note name macros to match with the userspace's expectation. Signed-off-by: Akihiko Odaki --- arch/s390/kernel/crash_dump.c | 62 --- 1 file

Re: [PATCH v3 5/6] s390/crash: Use note name macros

2025-01-07 Thread Dave Martin
Hi, On Tue, Jan 07, 2025 at 09:45:56PM +0900, Akihiko Odaki wrote: > Use note name macros to match with the userspace's expectation. > > Signed-off-by: Akihiko Odaki > --- > arch/s390/kernel/crash_dump.c | 62 > --- > 1 file changed, 23 insertions(+), 39

[PATCH v3 5/6] s390/crash: Use note name macros

2025-01-07 Thread Akihiko Odaki
Use note name macros to match with the userspace's expectation. Signed-off-by: Akihiko Odaki --- arch/s390/kernel/crash_dump.c | 62 --- 1 file changed, 23 insertions(+), 39 deletions(-) diff --git a/arch/s390/kernel/crash_dump.c b/arch/s390/kernel/crash_