RE: [PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-17 Thread Li Yang-r58472
> -Original Message- > From: Kumar Gala [mailto:[EMAIL PROTECTED] > Sent: Wednesday, October 17, 2007 10:13 PM > To: Li Yang-r58472 > Cc: [EMAIL PROTECTED]; linuxppc-dev@ozlabs.org > Subject: Re: [PATCH v3 3/9] add Freescale SerDes PHY support > {snip} This patch h

Re: [PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-17 Thread Kumar Gala
> diff --git a/arch/powerpc/sysdev/fsl_serdes.c b/arch/powerpc/sysdev/ > fsl_serdes.c > new file mode 100644 > index 000..5e91eb7 > --- /dev/null > +++ b/arch/powerpc/sysdev/fsl_serdes.c > @@ -0,0 +1,152 @@ > +/* > + * arch/powerpc/sysdev/fsl_serdes.c > + * > + * Copyright (C) 2007 Freescale

Re: [PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-15 Thread Arnd Bergmann
On Monday 15 October 2007, Li Yang-r58472 wrote: > I'd like to but of_iomap() couldn't provide the physical address of the > device used as identification. It looks like you only use the physical address for a single printk, so you could change that to print the full-name of the device node instea

RE: [PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-15 Thread Li Yang-r58472
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] > On Behalf Of Arnd Bergmann > Sent: Friday, October 12, 2007 10:34 PM > To: linuxppc-dev@ozlabs.org > Cc: linuxppc-dev@ozlabs.org; [EMAIL PROTECTED] > Subject: Re: [PATCH v3 3/9] add Free

Re: [PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-13 Thread Stephen Rothwell
On Fri, 12 Oct 2007 21:28:42 +0800 Li Yang <[EMAIL PROTECTED]> wrote: > > +++ b/arch/powerpc/sysdev/fsl_serdes.c > +static int __init setup_serdes(struct device_node *np) > +{ > + void __iomem *regs; > + const void *prot; Maybe "const char *prot" (it is used as a string). > + const un

Re: [PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-12 Thread Arnd Bergmann
On Friday 12 October 2007, Li Yang wrote: > The SerDes(serializer/deserializer) PHY block is a new SoC block used > in Freescale chips to support multiple serial interfaces, such as PCI > Express, SGMII, SATA. Some of my comments here are similar to those for the ata driver, so I won't be as verbo

[PATCH v3 3/9] add Freescale SerDes PHY support

2007-10-12 Thread Li Yang
The SerDes(serializer/deserializer) PHY block is a new SoC block used in Freescale chips to support multiple serial interfaces, such as PCI Express, SGMII, SATA. Signed-off-by: Li Yang <[EMAIL PROTECTED]> --- arch/powerpc/platforms/Kconfig |3 + arch/powerpc/sysdev/Makefile |1 + ar