RE: [PATCH v3 3/7] eSPI: add eSPI controller support

2010-10-07 Thread Hu Mingkai-B21284
; Subject: Re: [PATCH v3 3/7] eSPI: add eSPI controller support > > Hello Mingkai, > > There are mostly cosmetic comments down below. > > > + /* spin until TX is done */ > > + while (((events = mpc8xxx_spi_read_reg(®_base->event)) >

Re: [PATCH v3 3/7] eSPI: add eSPI controller support

2010-10-01 Thread Anton Vorontsov
Hello Mingkai, There are mostly cosmetic comments down below. On Thu, Sep 30, 2010 at 04:00:42PM +0800, Mingkai Hu wrote: [...] > +/* > + * Freescale eSPI controller driver. > + * > + * Copyright 2010 Freescale Semiconductor, Inc. > + * > + * This program is free software; you can redistribute i

[PATCH v3 3/7] eSPI: add eSPI controller support

2010-09-30 Thread Mingkai Hu
Add eSPI controller support based on the library code spi_fsl_lib.c. The eSPI controller is newer controller 85xx/Pxxx devices supported. There're some differences comparing to the SPI controller: 1. Has different register map and different bit definition So leave the code operated the registe