Re: [PATCH v3 2/8] DMA: Freescale: unify register access methods

2014-04-10 Thread Hongbo Zhang
On 04/10/2014 04:46 PM, David Laight wrote: From: hongbo.zh...@freescale.com Methods of accessing DMA contorller registers are inconsistent, some registers ^^ Thanks. sorry, that it a typo. I would wait to see if there are other defects I have to correct, if y

RE: [PATCH v3 2/8] DMA: Freescale: unify register access methods

2014-04-10 Thread David Laight
From: hongbo.zh...@freescale.com > Methods of accessing DMA contorller registers are inconsistent, some registers ^^ > are accessed by DMA_IN/OUT directly, while others are accessed by functions > get/set_* which are wrappers of DMA_IN/OUT, and even for the BCR regist

[PATCH v3 2/8] DMA: Freescale: unify register access methods

2014-04-10 Thread hongbo.zhang
From: Hongbo Zhang Methods of accessing DMA contorller registers are inconsistent, some registers are accessed by DMA_IN/OUT directly, while others are accessed by functions get/set_* which are wrappers of DMA_IN/OUT, and even for the BCR register, it is read by get_bcr but written by DMA_OUT. Th