Re: [PATCH v3 2/2] net/ps3_gelic: Cleanups, improve logging

2021-07-11 Thread Christophe Leroy
Geoff Levand a écrit : General source cleanups and improved logging messages. Describe a bit more what you do to cleanup and improve. Some of your changes are not cleanup , they increase the mess. You should read kernel coding style Signed-off-by: Geoff Levand --- drivers/net/ethernet

[PATCH v3 2/2] net/ps3_gelic: Cleanups, improve logging

2021-07-10 Thread Geoff Levand
General source cleanups and improved logging messages. Signed-off-by: Geoff Levand --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 395 ++- 1 file changed, 216 insertions(+), 179 deletions(-) diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/to