Re: [PATCH v3 15/18] ext4: switch to using the crc32c library

2024-11-04 Thread Eric Biggers
On Mon, Nov 04, 2024 at 07:59:00AM -0800, Darrick J. Wong wrote: > Hmm. Looking at your git branch (which was quite helpful to link to!) I > think for XFS we don't need to change the crc32c() calls, and the only > porting work that needs to be done is mirroring this Kconfig change? > And that does

Re: [PATCH v3 15/18] ext4: switch to using the crc32c library

2024-11-04 Thread Theodore Ts'o
On Sun, Nov 03, 2024 at 02:31:51PM -0800, Eric Biggers wrote: > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32c(). This is much simpler, and it improves > performance due to

Re: [PATCH v3 15/18] ext4: switch to using the crc32c library

2024-11-04 Thread Darrick J. Wong
On Sun, Nov 03, 2024 at 02:31:51PM -0800, Eric Biggers wrote: > From: Eric Biggers > > Now that the crc32c() library function directly takes advantage of > architecture-specific optimizations, it is unnecessary to go through the > crypto API. Just use crc32c(). This is much simpler, and it impr

[PATCH v3 15/18] ext4: switch to using the crc32c library

2024-11-03 Thread Eric Biggers
From: Eric Biggers Now that the crc32c() library function directly takes advantage of architecture-specific optimizations, it is unnecessary to go through the crypto API. Just use crc32c(). This is much simpler, and it improves performance due to eliminating the crypto API overhead. Reviewed-b