Re: [PATCH v3 1/2] net/ps3_gelic: Add gelic_descr structures

2021-07-17 Thread Geoff Levand
Hi Christophe, On 7/11/21 7:03 AM, Christophe Leroy wrote: > > Your patch has a lot of cosmetic changes. Several of them are just wrong. The > other ones belong to another patch. This patch should focus only on the  > changes it targets. > > Your patch is way too big and addresses several diffe

Re: [PATCH v3 1/2] net/ps3_gelic: Add gelic_descr structures

2021-07-11 Thread Christophe Leroy
Geoff Levand a écrit : Create two new structures, struct gelic_hw_regs and struct gelic_chain_link, and replace the corresponding members of struct gelic_descr with the new structures. struct gelic_hw_regs holds the register variables used by the gelic hardware device. struct gelic_chain_link

[PATCH v3 1/2] net/ps3_gelic: Add gelic_descr structures

2021-07-10 Thread Geoff Levand
Create two new structures, struct gelic_hw_regs and struct gelic_chain_link, and replace the corresponding members of struct gelic_descr with the new structures. struct gelic_hw_regs holds the register variables used by the gelic hardware device. struct gelic_chain_link holds variables used to ma