Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly

2016-04-28 Thread Arnd Bergmann
On Thursday 28 April 2016 11:08:41 Arnd Bergmann wrote: > I only see two of them anyway (dreamcast and sh03), so that should > be easy enough to do. For instance in arch/sh/boards/mach-sh03/rtc.c, > the sh03_time_init() function should register a platform driver, > whose probe function calls devm_r

Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly

2016-04-28 Thread Arnd Bergmann
On Wednesday 27 April 2016 19:21:22 Rich Felker wrote: > On Thu, Apr 28, 2016 at 12:34:18AM +0200, Arnd Bergmann wrote: > > The rtc-generic driver provides an architecture specific > > wrapper on top of the generic rtc_class_ops abstraction, > > and on sh, that goes through another indirection usin

Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly

2016-04-28 Thread Geert Uytterhoeven
Hi Rich, On Thu, Apr 28, 2016 at 1:21 AM, Rich Felker wrote: > Not a complaint about your patch, but I'd like to get rid of this > platform device and abstraction layer completely since it doesn't seem > like something that can be modeled correctly in device tree. When > you're done cleaning this

Re: [PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly

2016-04-27 Thread Rich Felker
On Thu, Apr 28, 2016 at 12:34:18AM +0200, Arnd Bergmann wrote: > The rtc-generic driver provides an architecture specific > wrapper on top of the generic rtc_class_ops abstraction, > and on sh, that goes through another indirection using > the rtc_sh_get_time/rtc_sh_set_time functions. > > This ch

[PATCH v3 04/16] rtc: sh: provide rtc_class_ops directly

2016-04-27 Thread Arnd Bergmann
The rtc-generic driver provides an architecture specific wrapper on top of the generic rtc_class_ops abstraction, and on sh, that goes through another indirection using the rtc_sh_get_time/rtc_sh_set_time functions. This changes the sh rtc-generic device to provide its rtc_class_ops directly, skip