Re: [PATCH v3 02/11] powerpc/mpc5121: Add machine restart support

2010-02-15 Thread Anatolij Gustschin
Hi Wolfram, On Wed, 10 Feb 2010 00:24:06 +0100 Wolfram Sang wrote: > Two comments: ... > > +void mpc512x_restart(char *cmd) > > +{ > > + struct mpc512x_reset_module *rm = reset_module_base; > > Why not using reset_module_base directly? I will fix it in v4 patch. > > @@ -62,4 +95,5 @@ void _

Re: [PATCH v3 02/11] powerpc/mpc5121: Add machine restart support

2010-02-09 Thread Grant Likely
On Fri, Feb 5, 2010 at 6:42 AM, Anatolij Gustschin wrote: > Add reset module registers representation and > machine restart callback for mpc5121 platform. > > Signed-off-by: Piotr Ziecik > Signed-off-by: Wolfgang Denk > Signed-off-by: Anatolij Gustschin > Cc: Grant Likely > Cc: John Rigby > -

Re: [PATCH v3 02/11] powerpc/mpc5121: Add machine restart support

2010-02-09 Thread Wolfram Sang
Hi, On Fri, Feb 05, 2010 at 02:42:48PM +0100, Anatolij Gustschin wrote: > Add reset module registers representation and > machine restart callback for mpc5121 platform. > Two comments: > Signed-off-by: Piotr Ziecik > Signed-off-by: Wolfgang Denk > Signed-off-by: Anatolij Gustschin > Cc: Gran

[PATCH v3 02/11] powerpc/mpc5121: Add machine restart support

2010-02-05 Thread Anatolij Gustschin
Add reset module registers representation and machine restart callback for mpc5121 platform. Signed-off-by: Piotr Ziecik Signed-off-by: Wolfgang Denk Signed-off-by: Anatolij Gustschin Cc: Grant Likely Cc: John Rigby --- Changes since v2: - call mpc512x_restart_init() explicitely from platfor