Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-20 Thread Grant Likely
On Mon, Apr 20, 2009 at 3:01 AM, Wolfgang Grandegger wrote: > Hi Ben, > > Wolfgang Grandegger wrote: >> Wolfgang Grandegger wrote: >>> Kumar Gala wrote: On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: >> So I'm a bit concerned with the output we now get: >> >> mpc-i2c

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-20 Thread Wolfgang Grandegger
Hi Ben, Wolfgang Grandegger wrote: > Wolfgang Grandegger wrote: >> Kumar Gala wrote: >>> On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: >>> > So I'm a bit concerned with the output we now get: > > mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) > > why 0? is that ri

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-09 Thread Wolfgang Grandegger
Wolfgang Grandegger wrote: > Kumar Gala wrote: >> On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: >> So I'm a bit concerned with the output we now get: mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) why 0? is that right? >>> This is the backward compatibility mo

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-08 Thread Wolfgang Grandegger
Kumar Gala wrote: > > On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: > >>> So I'm a bit concerned with the output we now get: >>> >>> mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) >>> >>> why 0? is that right? >> >> This is the backward compatibility mode using hard-coded FDR values

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-08 Thread Kumar Gala
On Apr 8, 2009, at 12:03 PM, Scott Wood wrote: On Wed, Apr 08, 2009 at 12:22:29AM -0500, Kumar Gala wrote: hrummm. As I mentioned in my reply, I'm not convinced that the board one is the right thing in this case. I would have preferred it to be deferred. which part? I missed this whol

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-08 Thread Scott Wood
On Wed, Apr 08, 2009 at 12:22:29AM -0500, Kumar Gala wrote: > >hrummm. As I mentioned in my reply, I'm not convinced that the board > >one is the right thing in this case. I would have preferred it to be > >deferred. > > which part? I missed this whole thread as I had it forwarding to my > de

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-08 Thread Kumar Gala
On Apr 8, 2009, at 2:25 AM, Wolfgang Grandegger wrote: So I'm a bit concerned with the output we now get: mpc-i2c fffe03000.i2c: clock 0 Hz (dfsrr=16 fdr=49) why 0? is that right? This is the backward compatibility mode using hard-coded FDR values. The output is missleading, I agree. Wo

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-08 Thread Wolfgang Grandegger
Kumar Gala wrote: > > On Apr 8, 2009, at 12:11 AM, Kumar Gala wrote: > >> >> On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: >> >>> This patch series makes the I2C bus speed configurable by using the >>> I2C node property "clock-frequency". If the property is not defined, >>> the old fixed

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-08 Thread Wolfgang Grandegger
Kumar Gala wrote: > > On Apr 8, 2009, at 12:16 AM, Grant Likely wrote: > >> On Tue, Apr 7, 2009 at 10:11 PM, Kumar Gala >> wrote: >>> >>> On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: >>> This patch series makes the I2C bus speed configurable by using the I2C node property "cl

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Grant Likely
On Tue, Apr 7, 2009 at 10:22 PM, Kumar Gala wrote: > > On Apr 8, 2009, at 12:16 AM, Grant Likely wrote: > >> On Tue, Apr 7, 2009 at 10:11 PM, Kumar Gala >> wrote: >>> >>> On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: >>> This patch series makes the I2C bus speed configurable by usin

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Kumar Gala
On Apr 8, 2009, at 12:11 AM, Kumar Gala wrote: On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: This patch series makes the I2C bus speed configurable by using the I2C node property "clock-frequency". If the property is not defined, the old fixed clock settings will be used for backwar

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Kumar Gala
On Apr 8, 2009, at 12:16 AM, Grant Likely wrote: On Tue, Apr 7, 2009 at 10:11 PM, Kumar Gala wrote: On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: This patch series makes the I2C bus speed configurable by using the I2C node property "clock-frequency". If the property is not define

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Grant Likely
On Tue, Apr 7, 2009 at 10:11 PM, Kumar Gala wrote: > > On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: > >> This patch series makes the I2C bus speed configurable by using the >> I2C node property "clock-frequency". If the property is not defined, >> the old fixed clock settings will be use

Re: [PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Kumar Gala
On Apr 7, 2009, at 3:20 AM, Wolfgang Grandegger wrote: This patch series makes the I2C bus speed configurable by using the I2C node property "clock-frequency". If the property is not defined, the old fixed clock settings will be used for backward compatibility. The property "fsl,preserve-clocki

[PATCH v3 0/5] i2c: i2c-mpc: make I2C bus speed configurable

2009-04-07 Thread Wolfgang Grandegger
This patch series makes the I2C bus speed configurable by using the I2C node property "clock-frequency". If the property is not defined, the old fixed clock settings will be used for backward compatibility. The property "fsl,preserve-clocking" allows to inherit the settings from the bootloader. Fur