Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-22 Thread Viorel Suman
Hi Rob, On Lu, 2019-01-21 at 09:23 -0600, Rob Herring wrote: > On Fri, Jan 18, 2019 at 11:46:42AM -0800, Nicolin Chen wrote: > > > > On Fri, Jan 18, 2019 at 01:16:24PM +, Viorel Suman wrote: > > > > > > > > > > > > > > > > > 1. Moved "dais" node from machine driver DTS node to device > > >

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-22 Thread Viorel Suman
Hi Nicolin, On Vi, 2019-01-18 at 11:46 -0800, Nicolin Chen wrote: > On Fri, Jan 18, 2019 at 01:16:24PM +, Viorel Suman wrote: > > > > > > > > > > > > > 1. Moved "dais" node from machine driver DTS node to device > > > > driver > > > > DTS node > > > >   as suggested by Rob. > > > That was n

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-21 Thread Rob Herring
On Fri, Jan 18, 2019 at 11:46:42AM -0800, Nicolin Chen wrote: > On Fri, Jan 18, 2019 at 01:16:24PM +, Viorel Suman wrote: > > > > 1. Moved "dais" node from machine driver DTS node to device driver > > > > DTS node > > > >   as suggested by Rob. > > > That was not what I suggested. You still hav

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-18 Thread Nicolin Chen
On Fri, Jan 18, 2019 at 01:16:24PM +, Viorel Suman wrote: > > > 1. Moved "dais" node from machine driver DTS node to device driver > > > DTS node > > >   as suggested by Rob. > > That was not what I suggested. You still have a virtual node which > > looks to me to be unnecessary. > > To me rem

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-18 Thread Viorel Suman
Hi Rob, Nicolin, All, On Jo, 2019-01-17 at 10:18 -0600, Rob Herring wrote: > On Thu, Jan 17, 2019 at 12:46:25PM +, Viorel Suman wrote: > > > > The patchset adds NXP Audio Mixer (AUDMIX) device and machine > > drivers and related DT bindings documentation. > > > > Changes since V2: > > 1. Mov

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-17 Thread Nicolin Chen
On Thu, Jan 17, 2019 at 02:22:18PM -0800, Nicolin Chen wrote: > On Thu, Jan 17, 2019 at 12:46:25PM +, Viorel Suman wrote: > > The patchset adds NXP Audio Mixer (AUDMIX) device and machine > > drivers and related DT bindings documentation. > > > > Changes since V2: > > 1. Moved "dais" node from

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-17 Thread Nicolin Chen
On Thu, Jan 17, 2019 at 12:46:25PM +, Viorel Suman wrote: > The patchset adds NXP Audio Mixer (AUDMIX) device and machine > drivers and related DT bindings documentation. > > Changes since V2: > 1. Moved "dais" node from machine driver DTS node to device driver DTS node > as suggested by Rob

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-17 Thread Rob Herring
On Thu, Jan 17, 2019 at 12:46:25PM +, Viorel Suman wrote: > The patchset adds NXP Audio Mixer (AUDMIX) device and machine > drivers and related DT bindings documentation. > > Changes since V2: > 1. Moved "dais" node from machine driver DTS node to device driver DTS node > as suggested by Rob

[PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-17 Thread Viorel Suman
The patchset adds NXP Audio Mixer (AUDMIX) device and machine drivers and related DT bindings documentation. Changes since V2: 1. Moved "dais" node from machine driver DTS node to device driver DTS node as suggested by Rob. Changes since V1: 1. Original patch split into distinct patches for the