Re: [PATCH v3 0/2] SPI support for fsl_soc and mpc832x_rdb

2007-08-09 Thread Segher Boessenkool
> - cosmetic cleanups (@01 -> @1); That's a correctness fix, not just cosmetics. > - other non-mandatory (device-id, device_type, compatible, ...) > properties removed from mmc node, today board file is using > of_find_node_by_name(), instead of of_find_compatible_node(); That's the

Re: [PATCH v3 0/2] SPI support for fsl_soc and mpc832x_rdb

2007-08-08 Thread Kumar Gala
On Aug 8, 2007, at 12:07 PM, Anton Vorontsov wrote: > Hi all, > > This is v3. The only objection I can imagine is about "fsl,device-id". > Though in the v2 nobody complained, thus it's stayed intact. > > If you want to, complain now. I'll give up and will remove it. ;-) :), here's my complaint f

[PATCH v3 0/2] SPI support for fsl_soc and mpc832x_rdb

2007-08-08 Thread Anton Vorontsov
Hi all, This is v3. The only objection I can imagine is about "fsl,device-id". Though in the v2 nobody complained, thus it's stayed intact. If you want to, complain now. I'll give up and will remove it. ;-) Changelog: v2 -> v3 o Device tree: - completely removed mmc node; - removed pio-hand