Re: [spi-devel-general] [PATCH v3] spi: Add PPC4xx SPI driver

2008-11-20 Thread David Brownell
On Thursday 30 October 2008, Jason Hanna wrote: > Also, any pointers to sample/test code incorporating a spi protocol > driver would be incredibly helpful. Look at Documentation/spi/*.c ... for user mode code hooking up through "spidev". > I'm very new to device driver > programming and don't r

Re: [PATCH v3] spi: Add PPC4xx SPI driver

2008-10-31 Thread Josh Boyer
On Fri, 31 Oct 2008 09:31:19 +0100 Stefan Roese <[EMAIL PROTECTED]> wrote: > On Wednesday 29 October 2008, Josh Boyer wrote: > > Looks pretty good. Just a few minor comments/questions below. > > Thanks. I also added some comments below. > > > Also, do you have a patch for a DTS file that gives

Re: [PATCH v3] spi: Add PPC4xx SPI driver

2008-10-31 Thread Stefan Roese
On Wednesday 29 October 2008, Josh Boyer wrote: > Looks pretty good. Just a few minor comments/questions below. Thanks. I also added some comments below. > Also, do you have a patch for a DTS file that gives an example of how to > instantiate the SPI stuff in the device tree? OK, I'll add a DTS

Re: [PATCH v3] spi: Add PPC4xx SPI driver

2008-10-30 Thread Jason Hanna
On Wed, Oct 29, 2008 at 10:53 AM, Josh Boyer <[EMAIL PROTECTED]> wrote: > Also, do you have a patch for a DTS file that gives an example of how to > instantiate the SPI stuff in the device tree? I'll second that request. I've updated the device tree for my Kilauea (405EX) board but am not sure I

Re: [PATCH v3] spi: Add PPC4xx SPI driver

2008-10-29 Thread Josh Boyer
On Sun, Oct 26, 2008 at 06:48:44AM +0100, Stefan Roese wrote: >This adds a SPI driver for the SPI controller found in the IBM/AMCC >4xx PowerPC's. > >Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> >Signed-off-by: Wolfgang Ocker <[EMAIL PROTECTED]> >--- >Changes in v3: >- When the device is removed

[PATCH v3] spi: Add PPC4xx SPI driver

2008-10-25 Thread Stefan Roese
This adds a SPI driver for the SPI controller found in the IBM/AMCC 4xx PowerPC's. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Wolfgang Ocker <[EMAIL PROTECTED]> --- Changes in v3: - When the device is removed the GPIOs are released. The memory for the GPIO array is freed. Ch