Re: [PATCH v3] powerpc/pci: Assign fixed PHB number based on device-tree properties

2016-03-19 Thread Gavin Shan
On Thu, Mar 17, 2016 at 05:03:46PM -0300, Guilherme G. Piccoli wrote: >The domain/PHB field of PCI addresses has its value obtained from a >global variable, incremented each time a new domain (represented by >struct pci_controller) is added on the system. The domain addition >process happens during

Re: [PATCH v3] powerpc/pci: Assign fixed PHB number based on device-tree properties

2016-03-19 Thread Guilherme G. Piccoli
On 03/18/2016 01:00 AM, Gavin Shan wrote: Apart from below minor issues to be fixed, it looks good to me. Reviewed-by: Gavin Shan Thanks for the review Gavin, I'll fix the else/if detail and send a v4. + } else { + if (machine_is(powernv)) { + prop

Re: [PATCH v3] powerpc/pci: Assign fixed PHB number based on device-tree properties

2016-03-19 Thread Gavin Shan
On Fri, Mar 18, 2016 at 09:37:57AM +1100, Gavin Shan wrote: >On Thu, Mar 17, 2016 at 05:03:46PM -0300, Guilherme G. Piccoli wrote: >>The domain/PHB field of PCI addresses has its value obtained from a >>global variable, incremented each time a new domain (represented by >>struct pci_controller) is

[PATCH v3] powerpc/pci: Assign fixed PHB number based on device-tree properties

2016-03-18 Thread Guilherme G. Piccoli
The domain/PHB field of PCI addresses has its value obtained from a global variable, incremented each time a new domain (represented by struct pci_controller) is added on the system. The domain addition process happens during boot or due to PCI device hotplug. As recent kernels are using predictab