Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-12 Thread Madhavan Srinivasan
On Tuesday 12 August 2014 05:45 PM, Alexander Graf wrote: > > On 12.08.14 13:35, Madhavan Srinivasan wrote: >> On Tuesday 12 August 2014 04:49 PM, Alexander Graf wrote: >>> On 12.08.14 07:17, Madhavan Srinivasan wrote: On Monday 11 August 2014 02:45 PM, Alexander Graf wrote: > On 11.08.14

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-12 Thread Alexander Graf
On 12.08.14 13:35, Madhavan Srinivasan wrote: On Tuesday 12 August 2014 04:49 PM, Alexander Graf wrote: On 12.08.14 07:17, Madhavan Srinivasan wrote: On Monday 11 August 2014 02:45 PM, Alexander Graf wrote: On 11.08.14 10:51, Benjamin Herrenschmidt wrote: On Mon, 2014-08-11 at 09:26 +0200, A

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-12 Thread Madhavan Srinivasan
On Tuesday 12 August 2014 04:49 PM, Alexander Graf wrote: > > On 12.08.14 07:17, Madhavan Srinivasan wrote: >> On Monday 11 August 2014 02:45 PM, Alexander Graf wrote: >>> On 11.08.14 10:51, Benjamin Herrenschmidt wrote: On Mon, 2014-08-11 at 09:26 +0200, Alexander Graf wrote: >> diff --g

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-12 Thread Alexander Graf
On 12.08.14 07:17, Madhavan Srinivasan wrote: On Monday 11 August 2014 02:45 PM, Alexander Graf wrote: On 11.08.14 10:51, Benjamin Herrenschmidt wrote: On Mon, 2014-08-11 at 09:26 +0200, Alexander Graf wrote: diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c index da86d9b..

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-11 Thread Madhavan Srinivasan
On Monday 11 August 2014 02:45 PM, Alexander Graf wrote: > > On 11.08.14 10:51, Benjamin Herrenschmidt wrote: >> On Mon, 2014-08-11 at 09:26 +0200, Alexander Graf wrote: diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c index da86d9b..d95014e 100644 --- a/arch/pow

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-11 Thread Alexander Graf
On 11.08.14 10:51, Benjamin Herrenschmidt wrote: On Mon, 2014-08-11 at 09:26 +0200, Alexander Graf wrote: diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c index da86d9b..d95014e 100644 --- a/arch/powerpc/kvm/emulate.c +++ b/arch/powerpc/kvm/emulate.c This should be book3s_e

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-11 Thread Benjamin Herrenschmidt
On Mon, 2014-08-11 at 09:26 +0200, Alexander Graf wrote: > > diff --git a/arch/powerpc/kvm/emulate.c b/arch/powerpc/kvm/emulate.c > > index da86d9b..d95014e 100644 > > --- a/arch/powerpc/kvm/emulate.c > > +++ b/arch/powerpc/kvm/emulate.c > > This should be book3s_emulate.c. Any reason we can't ma

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-11 Thread Alexander Graf
On 01.08.14 06:50, Madhavan Srinivasan wrote: This patch adds kernel side support for software breakpoint. Design is that, by using an illegal instruction, we trap to hypervisor via Emulation Assistance interrupt, where we check for the illegal instruction and accordingly we return to Host or Gu

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-10 Thread Madhavan Srinivasan
On Sunday 03 August 2014 09:21 PM, Segher Boessenkool wrote: >> +/* >> + * KVMPPC_INST_BOOK3S_DEBUG is debug Instruction for supporting Software >> Breakpoint. >> + * Based on PowerISA v2.07, Instruction with opcode 0s will be treated as >> illegal >> + * instruction. >> + */ > > "primary opcode

Re: [PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-08-03 Thread Segher Boessenkool
> +/* > + * KVMPPC_INST_BOOK3S_DEBUG is debug Instruction for supporting Software > Breakpoint. > + * Based on PowerISA v2.07, Instruction with opcode 0s will be treated as > illegal > + * instruction. > + */ "primary opcode 0" instead? > +#define OP_ZERO 0x0 Using 0x0 where yo

[PATCH v3] powerpc/kvm: support to handle sw breakpoint

2014-07-31 Thread Madhavan Srinivasan
This patch adds kernel side support for software breakpoint. Design is that, by using an illegal instruction, we trap to hypervisor via Emulation Assistance interrupt, where we check for the illegal instruction and accordingly we return to Host or Guest. Patch also adds support for software breakpo