Kamalesh Babulal writes:
> On Monday 13 November 2017 02:08 PM, Balbir Singh wrote:
>> On Fri, Nov 10, 2017 at 2:28 PM, Josh Poimboeuf wrote:
>>> On Fri, Nov 10, 2017 at 01:06:25PM +1100, Balbir Singh wrote:
On Fri, Nov 10, 2017 at 2:19 AM, Josh Poimboeuf
wrote:
> FWIW, I think i
On Monday 13 November 2017 02:08 PM, Balbir Singh wrote:
On Fri, Nov 10, 2017 at 2:28 PM, Josh Poimboeuf wrote:
On Fri, Nov 10, 2017 at 01:06:25PM +1100, Balbir Singh wrote:
On Fri, Nov 10, 2017 at 2:19 AM, Josh Poimboeuf wrote:
FWIW, I think it won't matter anyway. I'm currently pursuing t
On Fri, Nov 10, 2017 at 2:28 PM, Josh Poimboeuf wrote:
> On Fri, Nov 10, 2017 at 01:06:25PM +1100, Balbir Singh wrote:
>> On Fri, Nov 10, 2017 at 2:19 AM, Josh Poimboeuf wrote:
>> > FWIW, I think it won't matter anyway. I'm currently pursuing the option
>> > of inserting nops after local calls,
Josh Poimboeuf writes:
> On Fri, Nov 10, 2017 at 01:06:25PM +1100, Balbir Singh wrote:
>> On Fri, Nov 10, 2017 at 2:19 AM, Josh Poimboeuf wrote:
>> > FWIW, I think it won't matter anyway. I'm currently pursuing the option
>> > of inserting nops after local calls, because it has less runtime
>>
On Fri, Nov 10, 2017 at 01:06:25PM +1100, Balbir Singh wrote:
> On Fri, Nov 10, 2017 at 2:19 AM, Josh Poimboeuf wrote:
> > FWIW, I think it won't matter anyway. I'm currently pursuing the option
> > of inserting nops after local calls, because it has less runtime
> > complexity than using a stub.
On Fri, Nov 10, 2017 at 2:19 AM, Josh Poimboeuf wrote:
> On Thu, Nov 09, 2017 at 04:49:05PM +0530, Naveen N. Rao wrote:
>> > > > > d) Have kpatch-build do some other kind of transformation? For
>> > > > > example,
>> > > > >maybe it could generate klp stubs which the callee calls into.
>>
On Thu, Nov 09, 2017 at 04:49:05PM +0530, Naveen N. Rao wrote:
> > > > > d) Have kpatch-build do some other kind of transformation? For
> > > > > example,
> > > > >maybe it could generate klp stubs which the callee calls into.
> > > > > Each
> > > > >klp stub could then do a proper glob
Josh Poimboeuf wrote:
On Tue, Nov 07, 2017 at 12:31:05PM +0100, Torsten Duwe wrote:
On Tue, Nov 07, 2017 at 07:34:29PM +1100, Michael Ellerman wrote:
> > So, just brainstorming a bit, here are the possible solutions I can
> > think of:
> >
> > a) Create a special klp stub for such calls (as in K
Josh Poimboeuf writes:
> On Tue, Nov 07, 2017 at 12:31:05PM +0100, Torsten Duwe wrote:
>> On Tue, Nov 07, 2017 at 07:34:29PM +1100, Michael Ellerman wrote:
>> > > So, just brainstorming a bit, here are the possible solutions I can
>> > > think of:
>> > >
>> > > a) Create a special klp stub for suc
On Tue, Nov 07, 2017 at 12:31:05PM +0100, Torsten Duwe wrote:
> On Tue, Nov 07, 2017 at 07:34:29PM +1100, Michael Ellerman wrote:
> > > So, just brainstorming a bit, here are the possible solutions I can
> > > think of:
> > >
> > > a) Create a special klp stub for such calls (as in Kamalesh's patch
On Tue, Nov 07, 2017 at 07:34:29PM +1100, Michael Ellerman wrote:
> Josh Poimboeuf writes:
>
> > On Tue, Oct 31, 2017 at 07:39:59PM +0100, Torsten Duwe wrote:
> >> On Tue, Oct 31, 2017 at 09:53:16PM +0530, Naveen N . Rao wrote:
> >> > On 2017/10/31 03:30PM, Torsten Duwe wrote:
> >> > >
> >> > >
Josh Poimboeuf writes:
> On Tue, Oct 31, 2017 at 07:39:59PM +0100, Torsten Duwe wrote:
>> On Tue, Oct 31, 2017 at 09:53:16PM +0530, Naveen N . Rao wrote:
>> > On 2017/10/31 03:30PM, Torsten Duwe wrote:
>> > >
>> > > Maybe I failed to express my views properly; I find the whole approach
>> [...]
On Tue, Oct 31, 2017 at 07:39:59PM +0100, Torsten Duwe wrote:
> On Tue, Oct 31, 2017 at 09:53:16PM +0530, Naveen N . Rao wrote:
> > On 2017/10/31 03:30PM, Torsten Duwe wrote:
> > >
> > > Maybe I failed to express my views properly; I find the whole approach
> [...]
> > > NAK'd-by: Torsten Duwe
>
On Tuesday 31 October 2017 07:49 PM, Naveen N . Rao wrote:
Hi Kamalesh,
Sorry for the late review. Overall, the patch looks good to me. So:
Acked-by: Naveen N. Rao
However, I have a few minor comments which can be addressed in a
subsequent patch.
Thanks for the review.
[...]
diff --git a/
On Wed, Nov 1, 2017 at 5:39 AM, Torsten Duwe wrote:
> On Tue, Oct 31, 2017 at 09:53:16PM +0530, Naveen N . Rao wrote:
>> On 2017/10/31 03:30PM, Torsten Duwe wrote:
>> >
>> > Maybe I failed to express my views properly; I find the whole approach
> [...]
>> > NAK'd-by: Torsten Duwe
>>
>> Hmm... tha
On Tue, Oct 31, 2017 at 09:53:16PM +0530, Naveen N . Rao wrote:
> On 2017/10/31 03:30PM, Torsten Duwe wrote:
> >
> > Maybe I failed to express my views properly; I find the whole approach
[...]
> > NAK'd-by: Torsten Duwe
>
> Hmm... that wasn't evident at all given Balbir's reponse to your
> pre
On 2017/10/31 03:30PM, Torsten Duwe wrote:
> On Tue, Oct 31, 2017 at 07:49:59PM +0530, Naveen N . Rao wrote:
> > Hi Kamalesh,
> > Sorry for the late review. Overall, the patch looks good to me.
>
> If you're good with a hammer...
>
> Maybe I failed to express my views properly; I find the whole a
On Tue, Oct 31, 2017 at 07:49:59PM +0530, Naveen N . Rao wrote:
> Hi Kamalesh,
> Sorry for the late review. Overall, the patch looks good to me.
If you're good with a hammer...
Maybe I failed to express my views properly; I find the whole approach
mislead in the first place. I had asked questions
Hi Kamalesh,
Sorry for the late review. Overall, the patch looks good to me. So:
Acked-by: Naveen N. Rao
However, I have a few minor comments which can be addressed in a
subsequent patch.
On 2017/10/17 05:18AM, Kamalesh Babulal wrote:
> Livepatch re-uses module loader function apply_relocate_ad
Livepatch re-uses module loader function apply_relocate_add() to write
relocations, instead of managing them by arch-dependent
klp_write_module_reloc() function.
apply_relocate_add() doesn't understand livepatch symbols (marked with
SHN_LIVEPATCH symbol section index) and assumes them to be local
20 matches
Mail list logo
