Re: [PATCH v3] fsl_ucc_hdlc: process the result of hold_open()

2023-09-01 Thread Denis Kirjanov
On 9/1/23 13:48, Александра Дюпина wrote: > Thanks for the review! > > 28.08.2023 22:38, Jakub Kicinski пишет: >> Don't you have to undo all the things done prior to hdlc_open()? > Yes, it looks like I really need to undo everything that was done before > hdlc_open(). > But the question arose

Re: [PATCH v3] fsl_ucc_hdlc: process the result of hold_open()

2023-09-01 Thread Александра Дюпина
Thanks for the review! 28.08.2023 22:38, Jakub Kicinski пишет: Don't you have to undo all the things done prior to hdlc_open()? Yes, it looks like I really need to undo everything that was done before hdlc_open(). But the question arose - would it be enough to call the uhdlc_close(dev) functio

Re: [PATCH v3] fsl_ucc_hdlc: process the result of hold_open()

2023-08-28 Thread Jakub Kicinski
On Mon, 28 Aug 2023 15:12:35 +0300 Alexandra Diupina wrote: > Process the result of hold_open() and return it from > uhdlc_open() in case of an error > It is necessary to pass the error code up the control flow, > similar to a possible error in request_irq() > > Found by Linux Verification Center

Re: [PATCH v3] fsl_ucc_hdlc: process the result of hold_open()

2023-08-28 Thread Christophe Leroy
Le 28/08/2023 à 14:12, Alexandra Diupina a écrit : > [Vous ne recevez pas souvent de courriers de adiup...@astralinux.ru. > Découvrez pourquoi ceci est important à > https://aka.ms/LearnAboutSenderIdentification ] > > Process the result of hold_open() and return it from > uhdlc_open() in case

[PATCH v3] fsl_ucc_hdlc: process the result of hold_open()

2023-08-28 Thread Alexandra Diupina
Process the result of hold_open() and return it from uhdlc_open() in case of an error It is necessary to pass the error code up the control flow, similar to a possible error in request_irq() Found by Linux Verification Center (linuxtesting.org) with SVACE. Fixes: c19b6d246a35 ("drivers/net: suppo