Re: [PATCH v3] PPC4xx: Adding PCI(E) MSI support

2010-12-04 Thread Philipp Ittershagen
Hi, a few nitpicks here. I don't have any clue about MSI, but I have seen some code-style related issues. On 12/04/2010 02:33 AM, tma...@apm.com wrote: > +static int ppc4xx_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > +{ > + int err = 0; > + int int_no = -ENOMEM; > + unsi

[PATCH v3] PPC4xx: Adding PCI(E) MSI support

2010-12-03 Thread tmarri
From: Tirumala Marri This patch adds MSI support for 440SPe, 460Ex, 460Sx and 405Ex. Signed-off-by: Tirumala R Marri --- v3: * Rebased to Josh next tree * Cleanup and remove some unwanted log msg. * Remove list member and its references. * Keep msi_data local reference. v2: * Remove or ad