Re: [External] Re: [PATCH v3] PCI/ERR: Use pcie_aer_is_native() to judge whether OS owns AER

2022-08-12 Thread Zhuo Chen
On 8/3/22 6:18 AM, Sathyanarayanan Kuppuswamy wrote: On 7/27/22 2:37 AM, Zhuo Chen wrote: Do you mean changing "if ((host->native_aer || pcie_ports_native) && aer)" into "if  (pcie_aer_is_native(dev) && aer)" ? I thought changing into "if (pcie_aer_is_native(dev))" before. One another do

Re: [PATCH v3] PCI/ERR: Use pcie_aer_is_native() to judge whether OS owns AER

2022-08-02 Thread Sathyanarayanan Kuppuswamy
On 7/27/22 2:37 AM, Zhuo Chen wrote: >> > Do you mean changing "if ((host->native_aer || pcie_ports_native) && aer)"  > into "if (pcie_aer_is_native(dev) && aer)" ? > I thought changing into "if (pcie_aer_is_native(dev))" before. > > One another doubt. Not every pci device support aer. When dev

Re: [PATCH v3] PCI/ERR: Use pcie_aer_is_native() to judge whether OS owns AER

2022-07-27 Thread Zhuo Chen
On 7/26/22 1:35 PM, Zhuo Chen wrote: On 7/26/22 9:02 PM, Sathyanarayanan Kuppuswamy wrote: On 7/26/22 8:53 PM, Zhuo Chen wrote: Use pcie_aer_is_native() in place of "host->native_aer || pcie_ports_native" to judge whether OS has native control of AER in pcie_do_recovery(). Replace "dev->

Re: [PATCH v3] PCI/ERR: Use pcie_aer_is_native() to judge whether OS owns AER

2022-07-26 Thread 陈卓
On 7/26/22 9:02 PM, Sathyanarayanan Kuppuswamy wrote: On 7/26/22 8:53 PM, Zhuo Chen wrote: Use pcie_aer_is_native() in place of "host->native_aer || pcie_ports_native" to judge whether OS has native control of AER in pcie_do_recovery(). Replace "dev->aer_cap && (pcie_ports_native || host->n

Re: [PATCH v3] PCI/ERR: Use pcie_aer_is_native() to judge whether OS owns AER

2022-07-26 Thread Sathyanarayanan Kuppuswamy
On 7/26/22 8:53 PM, Zhuo Chen wrote: > Use pcie_aer_is_native() in place of "host->native_aer || > pcie_ports_native" to judge whether OS has native control of AER > in pcie_do_recovery(). > > Replace "dev->aer_cap && (pcie_ports_native || host->native_aer)" in > get_port_device_capability() wi

[PATCH v3] PCI/ERR: Use pcie_aer_is_native() to judge whether OS owns AER

2022-07-26 Thread Zhuo Chen
Use pcie_aer_is_native() in place of "host->native_aer || pcie_ports_native" to judge whether OS has native control of AER in pcie_do_recovery(). Replace "dev->aer_cap && (pcie_ports_native || host->native_aer)" in get_port_device_capability() with pcie_aer_is_native(), which has no functional cha